Hi Dan,
Can you clarify why the rx_buffer always holds little-endian data? It looks to
me like this buffer is filled by
wilc_sdio_cmd53(), which uses sdio_memcpy_toio(), which ultimately sets the
data with sg_set_buf(). This function
appears to use host-endian byte ordering.
Regards,
Perry
On
On Thu, Mar 23, 2017 at 04:15:06PM -0600, Robert Perry Hooker wrote:
> Well, yes, all data is 'endian' one way or another, right? I guess the byte
> order of the tx/rx_buffers is host-endian
> (which could be big), or _maybe_ network-endian...
The good news is this code is Open Source[tm] so we
Well, yes, all data is 'endian' one way or another, right? I guess the byte
order of the tx/rx_buffers is host-endian
(which could be big), or _maybe_ network-endian...
Regards,
Perry
On Thu, 2017-03-23 at 11:33 +0300, Dan Carpenter wrote:
> On Wed, Mar 22, 2017 at 07:53:28PM -0600, Robert
On Wed, Mar 22, 2017 at 07:53:28PM -0600, Robert Perry Hooker wrote:
> I don't think buff is an ieee80211_hdr struct. I think it's the rx_buffer
> allocated at wilc_wlan.c:1417.
>
The rx_buffer is going to end up filled with endian data, right?
regards,
dan carpenter
I don't think buff is an ieee80211_hdr struct. I think it's the rx_buffer
allocated at wilc_wlan.c:1417.
Regards,
Perry
On Wed, 2017-03-22 at 12:24 +0300, Dan Carpenter wrote:
> On Tue, Mar 21, 2017 at 03:40:10PM -0600, Robert Perry Hooker wrote:
> > Thanks for taking a look, Dan. Sorry if I
On Tue, Mar 21, 2017 at 03:40:10PM -0600, Robert Perry Hooker wrote:
> Thanks for taking a look, Dan. Sorry if I missed the mark here.
>
> Can you tell me a bit more about the bug this would introduce?
>
> I see that ieee80211_is_action is defined like this: static inline bool
>
Thanks for taking a look, Dan. Sorry if I missed the mark here.
Can you tell me a bit more about the bug this would introduce?
I see that ieee80211_is_action is defined like this: static inline bool
ieee80211_is_action(__le16 fc)
...and that buff[FRAME_TYPE_ID]is a u8 (since FRAME_TYPE_ID =
On Tue, Mar 21, 2017 at 01:55:40PM -0600, Perry Hooker wrote:
> This commit fixes the following sparse warnings:
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:1473:45: warning: incorrect
> type in argument 1 (different base types)
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51:
