Re: [PATCH] staging:r8723bs: remove wrappers around skb_clone()

2020-05-31 Thread Joe Perches
On Sun, 2020-05-31 at 20:28 +0300, Ivan Safonov wrote: > On 5/31/20 7:15 PM, Joe Perches wrote: > > On Sun, 2020-05-31 at 19:08 +0300, Ivan Safonov wrote: > > > Wrappers around skb_clone() do not simplify the driver code. > > [] > > > -inline struct sk_buff *_rtw_skb_clone(struct sk_buff *skb) > >

Re: [PATCH] staging:r8723bs: remove wrappers around skb_clone()

2020-05-31 Thread Ivan Safonov
On 5/31/20 8:36 PM, Joe Perches wrote: On Sun, 2020-05-31 at 20:28 +0300, Ivan Safonov wrote: On 5/31/20 7:15 PM, Joe Perches wrote: On Sun, 2020-05-31 at 19:08 +0300, Ivan Safonov wrote: Wrappers around skb_clone() do not simplify the driver code. [] -inline struct sk_buff

Re: [PATCH] staging:r8723bs: remove wrappers around skb_clone()

2020-05-31 Thread Ivan Safonov
On 5/31/20 7:15 PM, Joe Perches wrote: On Sun, 2020-05-31 at 19:08 +0300, Ivan Safonov wrote: Wrappers around skb_clone() do not simplify the driver code. [] -inline struct sk_buff *_rtw_skb_clone(struct sk_buff *skb) -{ - return skb_clone(skb, in_interrupt() ? GFP_ATOMIC : GFP_KERNEL);

Re: [PATCH] staging:r8723bs: remove wrappers around skb_clone()

2020-05-31 Thread Joe Perches
On Sun, 2020-05-31 at 19:08 +0300, Ivan Safonov wrote: > Wrappers around skb_clone() do not simplify the driver code. [] > -inline struct sk_buff *_rtw_skb_clone(struct sk_buff *skb) > -{ > - return skb_clone(skb, in_interrupt() ? GFP_ATOMIC : GFP_KERNEL); > -} > - [] > diff --git

[PATCH] staging:r8723bs: remove wrappers around skb_clone()

2020-05-31 Thread Ivan Safonov
Wrappers around skb_clone() do not simplify the driver code. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8723bs/include/osdep_service.h | 3 --- drivers/staging/rtl8723bs/os_dep/osdep_service.c | 5 - drivers/staging/rtl8723bs/os_dep/recv_linux.c | 2 +- 3 files changed, 1