Re: [PATCH] staging : android : fix checkpatch issues

2014-02-10 Thread DaeSeok Youn
OK. I will re-send this patch except replacing seq_printf() with seq_puts(). Your review helped me a lot. Thanks. Daeseok Youn. 2014-02-10 19:52 GMT+09:00 Dan Carpenter : > On Mon, Feb 10, 2014 at 07:23:46PM +0900, DaeSeok Youn wrote: >> Thanks for reviewing. >> >> Yes, I just followed by report

Re: [PATCH] staging : android : fix checkpatch issues

2014-02-10 Thread Dan Carpenter
On Mon, Feb 10, 2014 at 07:23:46PM +0900, DaeSeok Youn wrote: > Thanks for reviewing. > > Yes, I just followed by reports of checkpatch.pl. > > But I don't understand why I can use of seq_puts() in the middle of > seq_printf() calls. > I have been trying to search why that is not good but I didn'

Re: [PATCH] staging : android : fix checkpatch issues

2014-02-10 Thread DaeSeok Youn
Thanks for reviewing. Yes, I just followed by reports of checkpatch.pl. But I don't understand why I can use of seq_puts() in the middle of seq_printf() calls. I have been trying to search why that is not good but I didn't find anything about that. And I saw patches which were already merged simi

Re: [PATCH] staging : android : fix checkpatch issues

2014-02-10 Thread Dan Carpenter
On Mon, Feb 10, 2014 at 10:59:14AM +0900, Daeseok Youn wrote: > @@ -1376,14 +1376,14 @@ static int ion_debug_heap_show(struct seq_file *s, > void *unused) > } > } > mutex_unlock(&dev->buffer_lock); > - seq_printf(s, "---

Re: [PATCH] staging : android : fix checkpatch issues

2014-02-09 Thread DaeSeok Youn
2014-02-10 13:26 GMT+09:00 Greg KH : > On Mon, Feb 10, 2014 at 10:59:14AM +0900, Daeseok Youn wrote: >> >From 1348300b03697d0499eddba6035a851d1278abd1 Mon Sep 17 00:00:00 2001 >> From: Daeseok Youn >> Date: Mon, 10 Feb 2014 10:45:30 +0900 >> Subject: [PATCH] stag

Re: [PATCH] staging : android : fix checkpatch issues

2014-02-09 Thread Greg KH
On Mon, Feb 10, 2014 at 10:59:14AM +0900, Daeseok Youn wrote: > >From 1348300b03697d0499eddba6035a851d1278abd1 Mon Sep 17 00:00:00 2001 > From: Daeseok Youn > Date: Mon, 10 Feb 2014 10:45:30 +0900 > Subject: [PATCH] staging : android : fix checkpatch issues > > drivers/s

[PATCH] staging : android : fix checkpatch issues

2014-02-09 Thread Daeseok Youn
>From 1348300b03697d0499eddba6035a851d1278abd1 Mon Sep 17 00:00:00 2001 From: Daeseok Youn Date: Mon, 10 Feb 2014 10:45:30 +0900 Subject: [PATCH] staging : android : fix checkpatch issues drivers/staging/android/ ion/ion.c : - WARNNING: Unnecessary space after function pointer name - ER