Re: [PATCH -next] media: cedrus: fix reference leak in cedrus_start_streaming

2020-11-05 Thread Dan Carpenter
On Wed, Nov 04, 2020 at 12:39:11PM +0100, Hans Verkuil wrote: > On 02/11/2020 15:18, Maxime Ripard wrote: > > On Mon, Nov 02, 2020 at 10:26:22PM +0800, Zhang Qilong wrote: > >> pm_runtime_get_sync will increment pm usage counter even it > >> failed. Forgetting to pm_runtime_put_noidle will result i

答复: [PATCH -next] media: cedrus: fix reference leak in cedrus_start_streaming

2020-11-05 Thread zhangqilong
> On 02/11/2020 15:18, Maxime Ripard wrote: > > On Mon, Nov 02, 2020 at 10:26:22PM +0800, Zhang Qilong wrote: > >> pm_runtime_get_sync will increment pm usage counter even it failed. > >> Forgetting to pm_runtime_put_noidle will result in reference leak in > >> cedrus_start_streaming. We should fix

Re: [PATCH -next] media: cedrus: fix reference leak in cedrus_start_streaming

2020-11-04 Thread Hans Verkuil
On 02/11/2020 15:18, Maxime Ripard wrote: > On Mon, Nov 02, 2020 at 10:26:22PM +0800, Zhang Qilong wrote: >> pm_runtime_get_sync will increment pm usage counter even it >> failed. Forgetting to pm_runtime_put_noidle will result in >> reference leak in cedrus_start_streaming. We should fix it. >> >>

Re: [PATCH -next] media: cedrus: fix reference leak in cedrus_start_streaming

2020-11-02 Thread Dan Carpenter
On Mon, Nov 02, 2020 at 03:18:38PM +0100, Maxime Ripard wrote: > On Mon, Nov 02, 2020 at 10:26:22PM +0800, Zhang Qilong wrote: > > pm_runtime_get_sync will increment pm usage counter even it > > failed. Forgetting to pm_runtime_put_noidle will result in > > reference leak in cedrus_start_streaming.

答复: [PATCH -next] media: cedrus: fix reference leak in cedrus_start_streaming

2020-11-02 Thread zhangqilong
Hi > > On Mon, Nov 02, 2020 at 10:26:22PM +0800, Zhang Qilong wrote: > > pm_runtime_get_sync will increment pm usage counter even it failed. > > Forgetting to pm_runtime_put_noidle will result in reference leak in > > cedrus_start_streaming. We should fix it. > > > > Fixes: d5aecd289babf ("media:

Re: [PATCH -next] media: cedrus: fix reference leak in cedrus_start_streaming

2020-11-02 Thread Maxime Ripard
On Mon, Nov 02, 2020 at 10:26:22PM +0800, Zhang Qilong wrote: > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to pm_runtime_put_noidle will result in > reference leak in cedrus_start_streaming. We should fix it. > > Fixes: d5aecd289babf ("media: cedrus: Implement

[PATCH -next] media: cedrus: fix reference leak in cedrus_start_streaming

2020-11-02 Thread Zhang Qilong
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in cedrus_start_streaming. We should fix it. Fixes: d5aecd289babf ("media: cedrus: Implement runtime PM") Signed-off-by: Zhang Qilong --- drivers/staging/media/su