Re: [PATCH 0/3] Modernize tasklet callback API

2020-08-12 Thread Allen
Kees, > Was a Coccinelle script used for any of these conversions? I wonder if > it'd be easier to do a single treewide patch for the more mechanical > changes. No, I should have written one. Will do it. > And, actually, I still think the "prepare" patches should just be > collapsed into the

Re: [PATCH 0/3] Modernize tasklet callback API

2020-08-12 Thread Allen
> > I have a patch set to convert the remaining tasklet usage in sound > drivers to either the threaded IRQ or the work, but it wasn't > submitted / merged for 5.8 due to the obvious conflict with your API > changes. > Each conversion is rather simple, but it's always a question of the > nature of

Re: [PATCH 0/3] Modernize tasklet callback API

2020-08-12 Thread Takashi Iwai
On Tue, 11 Aug 2020 23:33:13 +0200, Kees Cook wrote: > > On Mon, Aug 03, 2020 at 02:16:15PM +0530, Allen wrote: > > Here's the series re-based on top of 5.8 > > https://github.com/allenpais/tasklets/tree/V3 > > Great! > > > Let me know how you would want these to be reviewed. > > Was a

Re: [PATCH 0/3] Modernize tasklet callback API

2020-08-11 Thread Kees Cook
On Mon, Aug 03, 2020 at 02:16:15PM +0530, Allen wrote: > Here's the series re-based on top of 5.8 > https://github.com/allenpais/tasklets/tree/V3 Great! > Let me know how you would want these to be reviewed. Was a Coccinelle script used for any of these conversions? I wonder if it'd be easier

Re: [PATCH 0/3] Modernize tasklet callback API

2020-08-11 Thread Allen
Kees, > > > > Here's the series re-based on top of 5.8 > https://github.com/allenpais/tasklets/tree/V3 > > Let me know how you would want these to be reviewed. > I see the first set of infrastructure patches for tasklets have landed in Linus's tree. Good time to send out the ~200 patches? -

Re: [PATCH 0/3] Modernize tasklet callback API

2020-08-03 Thread Allen
Kees, > > [heavily trimmed CC list because I think lkml is ignoring this > thread...] > > On Thu, Jul 30, 2020 at 09:03:55AM +0200, Thomas Gleixner wrote: > > Kees, > > > > Kees Cook writes: > > > This is the infrastructure changes to prepare the tasklet API for > > > conversion to passing the

Re: [PATCH 0/3] Modernize tasklet callback API

2020-07-30 Thread Kees Cook
[heavily trimmed CC list because I think lkml is ignoring this thread...] On Thu, Jul 30, 2020 at 09:03:55AM +0200, Thomas Gleixner wrote: > Kees, > > Kees Cook writes: > > This is the infrastructure changes to prepare the tasklet API for > > conversion to passing the tasklet struct as the

Re: [PATCH 0/3] Modernize tasklet callback API

2020-07-30 Thread Thomas Gleixner
Kees, Kees Cook writes: > This is the infrastructure changes to prepare the tasklet API for > conversion to passing the tasklet struct as the callback argument instead > of an arbitrary unsigned long. The first patch details why this is useful > (it's the same rationale as the timer_struct

Re: [PATCH 0/3] Modernize tasklet callback API

2020-07-16 Thread Kees Cook
On Thu, Jul 16, 2020 at 01:48:20PM -0700, Dmitry Torokhov wrote: > On Thu, Jul 16, 2020 at 12:14 PM Kees Cook wrote: > > > > On Thu, Jul 16, 2020 at 09:57:18AM +0200, Peter Zijlstra wrote: > > > On Wed, Jul 15, 2020 at 08:08:44PM -0700, Kees Cook wrote: > > > > Hi, > > > > > > > > This is the

Re: [PATCH 0/3] Modernize tasklet callback API

2020-07-16 Thread Dmitry Torokhov
On Thu, Jul 16, 2020 at 12:14 PM Kees Cook wrote: > > On Thu, Jul 16, 2020 at 09:57:18AM +0200, Peter Zijlstra wrote: > > On Wed, Jul 15, 2020 at 08:08:44PM -0700, Kees Cook wrote: > > > Hi, > > > > > > This is the infrastructure changes to prepare the tasklet API for > > > conversion to passing

Re: [PATCH 0/3] Modernize tasklet callback API

2020-07-16 Thread Kees Cook
On Thu, Jul 16, 2020 at 10:15:38AM +0200, Sebastian Andrzej Siewior wrote: > On 2020-07-16 09:57:18 [+0200], Peter Zijlstra wrote: > > > > there appear to be hardly any users left.. Can't we stage an extinction > > event here instead? > > Most of the time the tasklet is scheduled from an

Re: [PATCH 0/3] Modernize tasklet callback API

2020-07-16 Thread Kees Cook
On Thu, Jul 16, 2020 at 09:57:18AM +0200, Peter Zijlstra wrote: > On Wed, Jul 15, 2020 at 08:08:44PM -0700, Kees Cook wrote: > > Hi, > > > > This is the infrastructure changes to prepare the tasklet API for > > conversion to passing the tasklet struct as the callback argument instead > > of an

Re: [PATCH 0/3] Modernize tasklet callback API

2020-07-16 Thread Sebastian Andrzej Siewior
On 2020-07-16 09:57:18 [+0200], Peter Zijlstra wrote: > > there appear to be hardly any users left.. Can't we stage an extinction > event here instead? Most of the time the tasklet is scheduled from an interrupt handler. So we could get rid of these tasklets by using threaded IRQs. Sebastian

Re: [PATCH 0/3] Modernize tasklet callback API

2020-07-16 Thread Peter Zijlstra
On Wed, Jul 15, 2020 at 08:08:44PM -0700, Kees Cook wrote: > Hi, > > This is the infrastructure changes to prepare the tasklet API for > conversion to passing the tasklet struct as the callback argument instead > of an arbitrary unsigned long. The first patch details why this is useful > (it's

[PATCH 0/3] Modernize tasklet callback API

2020-07-15 Thread Kees Cook
Hi, This is the infrastructure changes to prepare the tasklet API for conversion to passing the tasklet struct as the callback argument instead of an arbitrary unsigned long. The first patch details why this is useful (it's the same rationale as the timer_struct changes from a bit ago: less abuse