Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-07-06 Thread Sergio Paracuellos
Hi Brett, On Sat, Jul 6, 2019 at 3:43 PM Brett Neumeier wrote: > > On Sat, Jul 6, 2019 at 4:00 AM Sergio Paracuellos > wrote: > > > Out of curiosity, if it's not too complex an answer to go into, what's > > > the benefit of the staging-next driver? Is there a reason to prefer it > > > to the

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-07-06 Thread Brett Neumeier
On Sat, Jul 6, 2019 at 4:00 AM Sergio Paracuellos wrote: > > Out of curiosity, if it's not too complex an answer to go into, what's > > the benefit of the staging-next driver? Is there a reason to prefer it > > to the 4.2 driver? > > In terms of stability, the driver which is in staging-next now

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-07-06 Thread Sergio Paracuellos
Hi Brett, On Fri, Jul 5, 2019 at 8:44 PM Brett Neumeier wrote: > > On Wed, Jun 26, 2019 at 7:45 AM Sergio Paracuellos > wrote: > > No problem, I also miss them rewritting code. That is bad :((. > > > BTW, I applied that on top of your other recent fixes (that ones > > > you pushed to gregkh

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-07-05 Thread Brett Neumeier
On Wed, Jun 26, 2019 at 7:45 AM Sergio Paracuellos wrote: > No problem, I also miss them rewritting code. That is bad :((. > > BTW, I applied that on top of your other recent fixes (that ones > > you pushed to gregkh for staging). So I tested with the > > updated GPIO reset code. > Ok, anyway..

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-26 Thread Sergio Paracuellos
Hi Greg, On Wed, Jun 26, 2019 at 2:18 PM Greg Ungerer wrote: > > Hi Sergio, > > On 26/6/19 5:10 pm, Sergio Paracuellos wrote: > > On Wed, Jun 26, 2019 at 5:31 AM Greg Ungerer wrote: > >> On 25/6/19 10:47 pm, Sergio Paracuellos wrote: > >>> On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos >

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-26 Thread Greg Ungerer
Hi Sergio, On 26/6/19 5:10 pm, Sergio Paracuellos wrote: On Wed, Jun 26, 2019 at 5:31 AM Greg Ungerer wrote: On 25/6/19 10:47 pm, Sergio Paracuellos wrote: On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos wrote: On Tue, Jun 25, 2019 at 7:10 AM Greg Ungerer wrote: On 23/6/19 3:58 pm,

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-26 Thread Sergio Paracuellos
Hi Greg, On Wed, Jun 26, 2019 at 5:31 AM Greg Ungerer wrote: > > Hi Sergio, > > On 25/6/19 10:47 pm, Sergio Paracuellos wrote: > > On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos > > wrote: > >> On Tue, Jun 25, 2019 at 7:10 AM Greg Ungerer wrote: > >>> On 23/6/19 3:58 pm, Sergio Paracuellos

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-25 Thread Greg Ungerer
Hi Sergio, On 25/6/19 10:47 pm, Sergio Paracuellos wrote: On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos wrote: On Tue, Jun 25, 2019 at 7:10 AM Greg Ungerer wrote: On 23/6/19 3:58 pm, Sergio Paracuellos wrote: On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier wrote: On Fri, Jun 21, 2019

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-25 Thread Sergio Paracuellos
Hi Greg, On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos wrote: > > Hi Greg, > > On Tue, Jun 25, 2019 at 7:10 AM Greg Ungerer wrote: > > > > Hi Sergio, > > > > On 23/6/19 3:58 pm, Sergio Paracuellos wrote: > > > On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier > > > wrote: > > >> On Fri, Jun

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-24 Thread Sergio Paracuellos
Hi Greg, On Tue, Jun 25, 2019 at 7:10 AM Greg Ungerer wrote: > > Hi Sergio, > > On 23/6/19 3:58 pm, Sergio Paracuellos wrote: > > On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier wrote: > >> On Fri, Jun 21, 2019 at 7:35 AM Greg Ungerer wrote: > >>> On 21/6/19 4:15 pm, Sergio Paracuellos wrote: >

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-24 Thread Greg Ungerer
Hi Sergio, On 23/6/19 3:58 pm, Sergio Paracuellos wrote: On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier wrote: On Fri, Jun 21, 2019 at 7:35 AM Greg Ungerer wrote: On 21/6/19 4:15 pm, Sergio Paracuellos wrote: This patch series properly handle minor issues in this driver. These are: *

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-22 Thread Sergio Paracuellos
Hi Brett, On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier wrote: > > On Fri, Jun 21, 2019 at 7:35 AM Greg Ungerer wrote: > > > > Hi Sergio, > > > > On 21/6/19 4:15 pm, Sergio Paracuellos wrote: > > > This patch series properly handle minor issues in this driver. These are: > > > * Disable pcie

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-22 Thread Brett Neumeier
On Fri, Jun 21, 2019 at 7:35 AM Greg Ungerer wrote: > > Hi Sergio, > > On 21/6/19 4:15 pm, Sergio Paracuellos wrote: > > This patch series properly handle minor issues in this driver. These are: > > * Disable pcie port clock on pci dirver instead of doing it in the phy > >driver. The pci

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-21 Thread Sergio Paracuellos
Hi Greg, On Fri, Jun 21, 2019 at 2:35 PM Greg Ungerer wrote: > > Hi Sergio, > > On 21/6/19 4:15 pm, Sergio Paracuellos wrote: > > This patch series properly handle minor issues in this driver. These are: > > * Disable pcie port clock on pci dirver instead of doing it in the phy > >driver.

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-21 Thread Greg Ungerer
Hi Sergio, On 21/6/19 4:15 pm, Sergio Paracuellos wrote: This patch series properly handle minor issues in this driver. These are: * Disable pcie port clock on pci dirver instead of doing it in the phy driver. The pci driver is the correct place to do this. * Add a missing call to phy_exit

[PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-21 Thread Sergio Paracuellos
This patch series properly handle minor issues in this driver. These are: * Disable pcie port clock on pci dirver instead of doing it in the phy driver. The pci driver is the correct place to do this. * Add a missing call to phy_exit function to properly handle the function