The `comedi_buf_read_samples()` and `comedi_buf_write_samples()` functions can read/write either 16-bit or 32-bit values from/to the Comedi buffer used for Comedi asynchonous command data. The width of the value depends on whether the subdevice sets the `SDF_LSAMPL` flag (indicating 32-bit samples, if set).
Various Comedi drivers are calling `comedi_buf_write_samples()` with the address of an object of type `unsigned int` when the subdevice is set to use 16-bit wide samples (`SDF_LSAMPL` flag clear). That will not work properly on bigendian machines because it will be transferring a 2-byte value from the wrong end of the 32-bit integer. This patch series fixes those problems. For some of the drivers, the value being transferred is always 0 anyway, so it doesn't matter much, but fix them anyway in patches 10 thru 14. 01) staging: comedi: addi_apci_1032: Fix endian problem for COS sample 02) staging: comedi: addi_apci_1500: Fix endian problem for command sample 03) staging: comedi: adv_pci1710: Fix endian problem for AI command data 04) staging: comedi: das6402: Fix endian problem for AI command data 05) staging: comedi: das800: Fix endian problem for AI command data 06) staging: comedi: dmm32at: Fix endian problem for AI command data 07) staging: comedi: me4000: Fix endian problem for AI command data 08) staging: comedi: pcl711: Fix endian problem for AI command data 09) staging: comedi: pcl818: Fix endian problem for AI command data 10) staging: comedi: amplc_pc236_common: Use 16-bit 0 for interrupt data 11) staging: comedi: comedi_parport: Use 16-bit 0 for interrupt data 12) staging: comedi: ni_6527: Use 16-bit 0 for interrupt data 13) staging: comedi: ni_65xx: Use 16-bit 0 for interrupt data 14) staging: comedi: pcl726: Use 16-bit 0 for interrupt data drivers/staging/comedi/drivers/addi_apci_1032.c | 4 +++- drivers/staging/comedi/drivers/addi_apci_1500.c | 18 +++++++++--------- drivers/staging/comedi/drivers/adv_pci1710.c | 10 +++++----- drivers/staging/comedi/drivers/amplc_pc236_common.c | 4 +++- drivers/staging/comedi/drivers/comedi_parport.c | 3 ++- drivers/staging/comedi/drivers/das6402.c | 2 +- drivers/staging/comedi/drivers/das800.c | 2 +- drivers/staging/comedi/drivers/dmm32at.c | 2 +- drivers/staging/comedi/drivers/me4000.c | 2 +- drivers/staging/comedi/drivers/ni_6527.c | 4 +++- drivers/staging/comedi/drivers/ni_65xx.c | 3 ++- drivers/staging/comedi/drivers/pcl711.c | 2 +- drivers/staging/comedi/drivers/pcl726.c | 4 +++- drivers/staging/comedi/drivers/pcl818.c | 2 +- 14 files changed, 36 insertions(+), 26 deletions(-) _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
