Re: [PATCH 00/23] Update driver to 0.9-294

2015-10-20 Thread Moni Shoua
> Understood, however, unlike SoftRoCE, qib and hfi currently share a lot of > code > to drive the hardware. > > The underlying reason for the TODO item "Remove software processing of IB > protocol..." is because we have a large amount of duplicated code between > these > drivers. _Some_ of whic

Re: [PATCH 00/23] Update driver to 0.9-294

2015-10-20 Thread ira.weiny
On Tue, Oct 20, 2015 at 03:45:47PM +0300, Moni Shoua wrote: > > > > Perhaps I did not chose my words carefully enough. > > > > The largest issue on the TODO list is the refactoring of the code to be > > shared between the hfi1 and qib driver. While the hardware between hfi1 > > and qib is similar

Re: [PATCH 00/23] Update driver to 0.9-294

2015-10-20 Thread Moni Shoua
> > Perhaps I did not chose my words carefully enough. > > The largest issue on the TODO list is the refactoring of the code to be > shared between the hfi1 and qib driver. While the hardware between hfi1 and > qib is similar and thus the initial code looked similar, our performance > tuning on

Re: [PATCH 00/23] Update driver to 0.9-294

2015-10-19 Thread Greg KH
On Mon, Oct 19, 2015 at 06:16:55PM +, Weiny, Ira wrote: > > > > On Mon, Oct 19, 2015 at 12:43:24PM -0400, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > The following series has bug fixes and updates to the staging hfi1 driver. > > > > Why are you adding new functionality to th

RE: [PATCH 00/23] Update driver to 0.9-294

2015-10-19 Thread Weiny, Ira
> > On Mon, Oct 19, 2015 at 12:43:24PM -0400, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > The following series has bug fixes and updates to the staging hfi1 driver. > > Why are you adding new functionality to this driver before it is moved out of > drivers/staging/ ? I _REALLY_ don't

Re: [PATCH 00/23] Update driver to 0.9-294

2015-10-19 Thread Greg KH
On Mon, Oct 19, 2015 at 12:43:24PM -0400, ira.we...@intel.com wrote: > From: Ira Weiny > > The following series has bug fixes and updates to the staging hfi1 driver. Why are you adding new functionality to this driver before it is moved out of drivers/staging/ ? I _REALLY_ don't like to see tha

[PATCH 00/23] Update driver to 0.9-294

2015-10-19 Thread ira . weiny
From: Ira Weiny The following series has bug fixes and updates to the staging hfi1 driver. Arthur Kepner (1): staging/rdma/hfi1: optionally prescan rx queue for {B,F}ECNs - UC, RC Caz Yokoyama (1): staging/rdma/hfi1: Reset firmware instead of reloading Sbus Dean Luick (4): staging/rdma/h