Re: [PATCH 00/31] staging: comedi: pcl711: cleanup driver

2013-09-24 Thread Ian Abbott
On 2013-09-23 17:38, Hartley Sweeten wrote: On Monday, September 23, 2013 9:23 AM, Ian Abbott wrote: I can take a look at the async command support once this series has been committed if you like. Basically, comedi_buf_put() can be used in the interrupt handler to write the sample to the comedi

RE: [PATCH 00/31] staging: comedi: pcl711: cleanup driver

2013-09-23 Thread Hartley Sweeten
On Monday, September 23, 2013 9:23 AM, Ian Abbott wrote: > On 2013-09-21 00:33, H Hartley Sweeten wrote: >> Tidy up this driver a bit. >> >> Unfortunately not a great reduction in the lines of code but it did >> uncover a couple bugs in the 8112 board and async command support. >> >> The async comm

Re: [PATCH 00/31] staging: comedi: pcl711: cleanup driver

2013-09-23 Thread Ian Abbott
On 2013-09-21 00:33, H Hartley Sweeten wrote: Tidy up this driver a bit. Unfortunately not a great reduction in the lines of code but it did uncover a couple bugs in the 8112 board and async command support. The async command support still needs to be looked over. 1) The analog input sample

[PATCH 00/31] staging: comedi: pcl711: cleanup driver

2013-09-20 Thread H Hartley Sweeten
Tidy up this driver a bit. Unfortunately not a great reduction in the lines of code but it did uncover a couple bugs in the 8112 board and async command support. The async command support still needs to be looked over. 1) The analog input sample read in the interrupt routine is not returne