Re: [PATCH 00/32] staging: comedi: continue async command cleanup

2014-05-03 Thread gre...@linuxfoundation.org
On Tue, Apr 29, 2014 at 08:07:55PM +, Hartley Sweeten wrote: On Tuesday, April 29, 2014 12:59 PM, H Hartley Sweeten wrote: Remove some unnecessary pacer divisor calculations. The divisors are calculated as part of the (*do_cmdtest) and don't need done in the (*do_cmd). Remove the

Re: [PATCH 00/32] staging: comedi: continue async command cleanup

2014-05-01 Thread Ian Abbott
On 2014-04-30 17:46, Hartley Sweeten wrote: On Wednesday, April 30, 2014 2:13 AM, Ian Abbott wrote: As a side node, I wonder if it's worth stripping out those `| I8254_BINARY` bits as it's basically 'OR'ing with zero anyway. I like the I8254_BINARY, it documents the mode that the counter is

RE: [PATCH 00/32] staging: comedi: continue async command cleanup

2014-05-01 Thread Hartley Sweeten
On Thursday, May 01, 2014 2:46 AM, Ian Abbott wrote: On 2014-04-30 17:46, Hartley Sweeten wrote: On Wednesday, April 30, 2014 2:13 AM, Ian Abbott wrote: As a side node, I wonder if it's worth stripping out those `| I8254_BINARY` bits as it's basically 'OR'ing with zero anyway. I like the

Re: [PATCH 00/32] staging: comedi: continue async command cleanup

2014-05-01 Thread Ian Abbott
On 2014-05-01 17:31, Hartley Sweeten wrote: BTW, what's with all the NI_GPCT_* stuff in the main comedi.h header? These all seem pretty driver specific to ni_tio.c and ni_tiocmd.c. I don't understand why they are exposed in the user space header. Basically for the same reason the 8254 mode

Re: [PATCH 00/32] staging: comedi: continue async command cleanup

2014-04-30 Thread Ian Abbott
On 2014-04-29 20:59, H Hartley Sweeten wrote: Remove some unnecessary pacer divisor calculations. The divisors are calculated as part of the (*do_cmdtest) and don't need done in the (*do_cmd). Remomove the older, unused, divisor calc functions in 8253.h to avoid any confusion. Remove some

RE: [PATCH 00/32] staging: comedi: continue async command cleanup

2014-04-30 Thread Hartley Sweeten
On Wednesday, April 30, 2014 2:13 AM, Ian Abbott wrote: On 2014-04-29 20:59, H Hartley Sweeten wrote: Remove some unnecessary pacer divisor calculations. The divisors are calculated as part of the (*do_cmdtest) and don't need done in the (*do_cmd). Remomove the older, unused, divisor calc

[PATCH 00/32] staging: comedi: continue async command cleanup

2014-04-29 Thread H Hartley Sweeten
Remove some unnecessary pacer divisor calculations. The divisors are calculated as part of the (*do_cmdtest) and don't need done in the (*do_cmd). Remomove the older, unused, divisor calc functions in 8253.h to avoid any confusion. Remove some unnecessary private data members in a couple drivers

RE: [PATCH 00/32] staging: comedi: continue async command cleanup

2014-04-29 Thread Hartley Sweeten
On Tuesday, April 29, 2014 12:59 PM, H Hartley Sweeten wrote: Remove some unnecessary pacer divisor calculations. The divisors are calculated as part of the (*do_cmdtest) and don't need done in the (*do_cmd). Remove the older, unused, divisor calc functions in 8253.h to avoid any confusion.