Re: [PATCH 01/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

2019-07-01 Thread Greg Kroah-Hartman
On Sat, Jun 29, 2019 at 03:49:09PM +0530, Hariprasad Kelam wrote: > fix below issues reported by checkpatch > > CHECK: Using comparison to false is error prone > CHECK: Using comparison to true is error prone > > Signed-off-by: Hariprasad Kelam > --- > drivers/staging/rtl8723bs/hal/hal_intf.c

Re: [PATCH 01/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

2019-06-29 Thread Dan Carpenter
You sent 10 patches with the same subject. Btw, I can't recall ever seeing a bug caused by a true false comparison. I agree on style principles with the checkpatch warning, but I do think it over states the risk (which is as far as I can see is zero). regards, dan carpenter

[PATCH 01/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

2019-06-29 Thread Hariprasad Kelam
fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_intf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git