Re: [PATCH 01/18] staging: ks7010: replace defines with enums

2017-04-14 Thread Greg Kroah-Hartman
On Wed, Apr 12, 2017 at 09:56:46AM +1000, Tobin C. Harding wrote: > Header has multiple constants defined using preprocessor > directive. In the cases where these are an integer progression an > enumeration type can be used. Doing so adds documentation to the code > and makes the usage explicit. >

[PATCH 01/18] staging: ks7010: replace defines with enums

2017-04-11 Thread Tobin C. Harding
Header has multiple constants defined using preprocessor directive. In the cases where these are an integer progression an enumeration type can be used. Doing so adds documentation to the code and makes the usage explicit. Replace (integer progression) preprocessor constants with enumeration type.