Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-09-10 Thread Greg KH
On Wed, Aug 29, 2018 at 09:35:27PM +0100, John Whitmore wrote: > Rename the bit field element AdvCoding, as it causes a checkpatch issue > with CamelCase naming. As the element is not actually used in code it > has been renamed to 'not_used_adv_coding'. > > The single line of code which

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-08-31 Thread John Whitmore
On Thu, Aug 30, 2018 at 03:34:01PM -0700, Joe Perches wrote: > On Wed, 2018-08-29 at 22:55 +0100, John Whitmore wrote: > > On Wed, Aug 29, 2018 at 04:21:54PM -0500, Larry Finger wrote: > > > On 08/29/2018 04:14 PM, Joe Perches wrote: > [] > > > > Perhaps support for the chipset could be converted

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-08-31 Thread Dan Carpenter
On Thu, Aug 30, 2018 at 10:35:37PM +0100, John Whitmore wrote: > On Thu, Aug 30, 2018 at 11:26:28AM +0300, Dan Carpenter wrote: > > On Thu, Aug 30, 2018 at 11:23:05AM +0300, Dan Carpenter wrote: > > > On Wed, Aug 29, 2018 at 09:35:27PM +0100, John Whitmore wrote: > > > > Rename the bit field

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-08-30 Thread Joe Perches
On Wed, 2018-08-29 at 22:55 +0100, John Whitmore wrote: > On Wed, Aug 29, 2018 at 04:21:54PM -0500, Larry Finger wrote: > > On 08/29/2018 04:14 PM, Joe Perches wrote: [] > > > Perhaps support for the chipset could be converted to use > > > mac80211 and moved into the directory with the other

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-08-30 Thread John Whitmore
On Thu, Aug 30, 2018 at 11:26:28AM +0300, Dan Carpenter wrote: > On Thu, Aug 30, 2018 at 11:23:05AM +0300, Dan Carpenter wrote: > > On Wed, Aug 29, 2018 at 09:35:27PM +0100, John Whitmore wrote: > > > Rename the bit field element AdvCoding, as it causes a checkpatch issue > > > with CamelCase

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-08-30 Thread Dan Carpenter
On Thu, Aug 30, 2018 at 11:23:05AM +0300, Dan Carpenter wrote: > On Wed, Aug 29, 2018 at 09:35:27PM +0100, John Whitmore wrote: > > Rename the bit field element AdvCoding, as it causes a checkpatch issue > > with CamelCase naming. As the element is not actually used in code it > > has been renamed

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-08-30 Thread Dan Carpenter
On Wed, Aug 29, 2018 at 09:35:27PM +0100, John Whitmore wrote: > Rename the bit field element AdvCoding, as it causes a checkpatch issue > with CamelCase naming. As the element is not actually used in code it > has been renamed to 'not_used_adv_coding'. > > The single line of code which

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-08-29 Thread John Whitmore
On Wed, Aug 29, 2018 at 04:21:54PM -0500, Larry Finger wrote: > On 08/29/2018 04:14 PM, Joe Perches wrote: > > On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote: > > > Rename the bit field element AdvCoding, as it causes a checkpatch issue > > > with CamelCase naming. As the element is not

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-08-29 Thread Larry Finger
On 08/29/2018 04:14 PM, Joe Perches wrote: On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote: Rename the bit field element AdvCoding, as it causes a checkpatch issue with CamelCase naming. As the element is not actually used in code it has been renamed to 'not_used_adv_coding'. The single

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-08-29 Thread Joe Perches
On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote: > Rename the bit field element AdvCoding, as it causes a checkpatch issue > with CamelCase naming. As the element is not actually used in code it > has been renamed to 'not_used_adv_coding'. > > The single line of code which initialises the

[PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-08-29 Thread John Whitmore
Rename the bit field element AdvCoding, as it causes a checkpatch issue with CamelCase naming. As the element is not actually used in code it has been renamed to 'not_used_adv_coding'. The single line of code which initialises the bit has been removed, as the field is unused. This is a purely