Re: [PATCH 01/23] staging: comedi: cb_pcidas: don't calc ai pacer divisors twice

2014-04-29 Thread Ian Abbott
On 29/04/14 18:56, Hartley Sweeten wrote: On Tuesday, April 29, 2014 7:52 AM, Ian Abbott wrote: On 2014-04-28 19:53, H Hartley Sweeten wrote: - /* Write the values of ctr1 and ctr2 into counters 1 and 2 */ - i8254_load(devpriv->pacer_counter_dio + ADC8254, 0, 1, - d

RE: [PATCH 01/23] staging: comedi: cb_pcidas: don't calc ai pacer divisors twice

2014-04-29 Thread Hartley Sweeten
On Tuesday, April 29, 2014 7:52 AM, Ian Abbott wrote: > On 2014-04-28 19:53, H Hartley Sweeten wrote: >> The analog input async command can use the pacer for the scan_bagin_src >> or the convert_src. The (*do_cmdtest) validates that only one of these >> sources has the TRIG_TIMER selected and calcu

Re: [PATCH 01/23] staging: comedi: cb_pcidas: don't calc ai pacer divisors twice

2014-04-29 Thread Ian Abbott
On 2014-04-28 19:53, H Hartley Sweeten wrote: The analog input async command can use the pacer for the scan_bagin_src or the convert_src. The (*do_cmdtest) validates that only one of these sources has the TRIG_TIMER selected and calculates the divisors when validating the cmd argument. There is

[PATCH 01/23] staging: comedi: cb_pcidas: don't calc ai pacer divisors twice

2014-04-28 Thread H Hartley Sweeten
The analog input async command can use the pacer for the scan_bagin_src or the convert_src. The (*do_cmdtest) validates that only one of these sources has the TRIG_TIMER selected and calculates the divisors when validating the cmd argument. There is no reason to recalc the divisors in the (*do_cmd