Re: [PATCH 02/11] staging: iio: adt7316: invert the logic of the check for an ldac pin

2018-12-16 Thread Jonathan Cameron
On Fri, 14 Dec 2018 09:18:20 +0300 Dan Carpenter wrote: > On Thu, Dec 13, 2018 at 03:06:29PM -0700, Jeremy Fertic wrote: > > On Wed, Dec 12, 2018 at 11:19:49AM +0300, Dan Carpenter wrote: > > > On Tue, Dec 11, 2018 at 05:54:54PM -0700, Jeremy Fertic wrote: > > > > ADT7316_DA_EN_VIA_DAC_LDCA i

Re: [PATCH 02/11] staging: iio: adt7316: invert the logic of the check for an ldac pin

2018-12-13 Thread Dan Carpenter
On Thu, Dec 13, 2018 at 03:06:29PM -0700, Jeremy Fertic wrote: > On Wed, Dec 12, 2018 at 11:19:49AM +0300, Dan Carpenter wrote: > > On Tue, Dec 11, 2018 at 05:54:54PM -0700, Jeremy Fertic wrote: > > > ADT7316_DA_EN_VIA_DAC_LDCA is set when the dac and ldac registers are > > > being > > > used to u

Re: [PATCH 02/11] staging: iio: adt7316: invert the logic of the check for an ldac pin

2018-12-13 Thread Jeremy Fertic
On Wed, Dec 12, 2018 at 11:19:49AM +0300, Dan Carpenter wrote: > On Tue, Dec 11, 2018 at 05:54:54PM -0700, Jeremy Fertic wrote: > > ADT7316_DA_EN_VIA_DAC_LDCA is set when the dac and ldac registers are being > > used to update the dacs instead of the ldac pin. ADT7516_SEL_AIN3 is an adc > > input t

Re: [PATCH 02/11] staging: iio: adt7316: invert the logic of the check for an ldac pin

2018-12-12 Thread Dan Carpenter
On Tue, Dec 11, 2018 at 05:54:54PM -0700, Jeremy Fertic wrote: > ADT7316_DA_EN_VIA_DAC_LDCA is set when the dac and ldac registers are being > used to update the dacs instead of the ldac pin. ADT7516_SEL_AIN3 is an adc > input that shares the ldac pin. Only set these bits if an ldac pin is not > be

[PATCH 02/11] staging: iio: adt7316: invert the logic of the check for an ldac pin

2018-12-11 Thread Jeremy Fertic
ADT7316_DA_EN_VIA_DAC_LDCA is set when the dac and ldac registers are being used to update the dacs instead of the ldac pin. ADT7516_SEL_AIN3 is an adc input that shares the ldac pin. Only set these bits if an ldac pin is not being used. Signed-off-by: Jeremy Fertic --- drivers/staging/iio/addac