On Sun, Apr 20, 2014 at 02:17:11PM +0530, navin patidar wrote:
_ReadLEDSetting() doesn't read led settings this function actually
initialize member variables of struct led_priv, we should do that
inside rtl8188eu_InitSwLeds().
This seems like a bugfix or is it just a cleanup? It's not
Hi dan
it's just a cleanup patch and i also tested all patches of this patch
series on the hardware (TP-LINK TL-WN723N).
my mistake i should have added Tested-by tag for all patches.
Tested-by: navin patidar navin.pati...@gmail.com
regards,
--navin-patidar
On Tue, Apr 22, 2014 at 3:41 PM, Dan
On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote:
Hi dan
it's just a cleanup patch and i also tested all patches of this patch
series on the hardware (TP-LINK TL-WN723N).
my mistake i should have added Tested-by tag for all patches.
Tested-by: navin patidar
On 04/22/2014 09:14 AM, Dan Carpenter wrote:
On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote:
Hi dan
it's just a cleanup patch and i also tested all patches of this patch
series on the hardware (TP-LINK TL-WN723N).
my mistake i should have added Tested-by tag for all patches.
I sometimes mark my patches as untested and there are a couple other
people who do as well. For the staging tree probably 80% of the patches
are not tested. I kind of know who regular developers are and who tests
their patches.
But one thing I really want to stress is that if I ask something
On Tue, Apr 22, 2014 at 7:58 PM, Larry Finger larry.fin...@lwfinger.net wrote:
To me, the opposite case is true. If you have not tested, then you need to
explicitly state compile tested only in the commit message. Without saying
that, your signed-off-by is implying that you have tested, as
_ReadLEDSetting() doesn't read led settings this function actually
initialize member variables of struct led_priv, we should do that
inside rtl8188eu_InitSwLeds().
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/hal/rtl8188eu_led.c |4
