RE: [PATCH 03/18] staging/rdma/hfi1: Add aeth name syndrome decode

2015-11-20 Thread Marciniszyn, Mike
> > Add aeth name syndrome decode > > Again, why? > This fix is to enhance debugging. The IBTA RC ACK contains an ACK extended transport header. Part of that header is the syndrome field that qualifies the RC ACK as an ACK, NAK, or RNR NAK. Without the patch here is the syndrome decode: aeth

Re: [PATCH 03/18] staging/rdma/hfi1: Add aeth name syndrome decode

2015-11-19 Thread Greg KH
On Fri, Nov 13, 2015 at 07:37:01PM -0800, Jubin John wrote: > From: Dean Luick > > Add aeth name syndrome decode Again, why? Come on, be more descriptive about why you are making the change, not what the change is, we can all read code. Please fix this whole series up and resend. thanks, gre

[PATCH 03/18] staging/rdma/hfi1: Add aeth name syndrome decode

2015-11-13 Thread Jubin John
From: Dean Luick Add aeth name syndrome decode Reviewed-by: Mike Marciniszyn Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/trace.c | 29 ++--- 1 files changed, 22 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rdma/hf