Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver

2017-09-05 Thread Hans de Goede
Hi, On 04-09-17 13:19, Peter Rosin wrote: Hi! Some comments inline... On 2017-09-01 23:48, Hans de Goede wrote: Intel Cherrytrail SoCs have an internal USB mux for muxing the otg-port USB data lines between the xHCI host controller and the dwc3 gadget controller. On some Cherrytrail systems

Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver

2017-09-04 Thread Hans de Goede
Hi, Thank you for the reviews! On 02-09-17 12:19, Andy Shevchenko wrote: On Sat, Sep 2, 2017 at 12:48 AM, Hans de Goede wrote: Intel Cherrytrail SoCs have an internal USB mux for muxing the otg-port USB data lines between the xHCI host controller and the dwc3 gadget

Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver

2017-09-04 Thread Peter Rosin
Hi! Some comments inline... On 2017-09-01 23:48, Hans de Goede wrote: > Intel Cherrytrail SoCs have an internal USB mux for muxing the otg-port > USB data lines between the xHCI host controller and the dwc3 gadget > controller. On some Cherrytrail systems this mux is controlled through > AML

Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver

2017-09-02 Thread Andy Shevchenko
On Sat, Sep 2, 2017 at 12:48 AM, Hans de Goede wrote: > Intel Cherrytrail SoCs have an internal USB mux for muxing the otg-port > USB data lines between the xHCI host controller and the dwc3 gadget > controller. On some Cherrytrail systems this mux is controlled through > AML

[PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver

2017-09-01 Thread Hans de Goede
Intel Cherrytrail SoCs have an internal USB mux for muxing the otg-port USB data lines between the xHCI host controller and the dwc3 gadget controller. On some Cherrytrail systems this mux is controlled through AML code reacting on a GPIO IRQ connected to the USB OTG id pin (through an _AIE ACPI