Re: [PATCH 05/18] staging: gasket: sysfs mapping creation fixups

2018-07-16 Thread Greg Kroah-Hartman
On Mon, Jul 16, 2018 at 02:14:27PM -0700, Todd Poynor wrote: > On Fri, Jul 13, 2018 at 11:32 PM, Greg Kroah-Hartman > wrote: > > On Fri, Jul 13, 2018 at 10:58:03PM -0700, Todd Poynor wrote: > >> From: Todd Poynor > >> > >> Return EBUSY for attempt to create a mapping already in use. > > > > Why?

Re: [PATCH 05/18] staging: gasket: sysfs mapping creation fixups

2018-07-16 Thread Todd Poynor
On Fri, Jul 13, 2018 at 11:32 PM, Greg Kroah-Hartman wrote: > On Fri, Jul 13, 2018 at 10:58:03PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> Return EBUSY for attempt to create a mapping already in use. > > Why? The existing code returns EINVAL which often means something bogus was reque

Re: [PATCH 05/18] staging: gasket: sysfs mapping creation fixups

2018-07-13 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:03PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Return EBUSY for attempt to create a mapping already in use. Why? > Remove stale pointers on error allocating attr array. This should be a different patch. thanks, greg k-h __

[PATCH 05/18] staging: gasket: sysfs mapping creation fixups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Return EBUSY for attempt to create a mapping already in use. Remove stale pointers on error allocating attr array. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -