Re: [PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

2018-07-16 Thread Todd Poynor
On Sat, Jul 14, 2018 at 5:57 AM, Greg Kroah-Hartman wrote: > On Sat, Jul 14, 2018 at 11:07:21AM +0300, Dmitry Torokhov wrote: >> On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor wrote: >> > >> > From: Todd Poynor >> > >> > g_mutex held across pci_unregister_driver() call, also held in >> > gasket_pci

Re: [PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

2018-07-14 Thread Greg Kroah-Hartman
On Sat, Jul 14, 2018 at 11:07:21AM +0300, Dmitry Torokhov wrote: > On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor wrote: > > > > From: Todd Poynor > > > > g_mutex held across pci_unregister_driver() call, also held in > > gasket_pci_remove(), which deadlocks. > > > > Reported-by: Dmitry Torokhov >

Re: [PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

2018-07-14 Thread Dmitry Torokhov
On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor wrote: > > From: Todd Poynor > > g_mutex held across pci_unregister_driver() call, also held in > gasket_pci_remove(), which deadlocks. > > Reported-by: Dmitry Torokhov > Signed-off-by: Zhongze Hu > Signed-off-by: Todd Poynor > --- > drivers/staging

Re: [PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

2018-07-13 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:04PM -0700, Todd Poynor wrote: > From: Todd Poynor > > g_mutex held across pci_unregister_driver() call, also held in > gasket_pci_remove(), which deadlocks. Which reminds me, why in the world do you all wrap pci register/unregister within your new subsystem? That'

[PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

2018-07-13 Thread Todd Poynor
From: Todd Poynor g_mutex held across pci_unregister_driver() call, also held in gasket_pci_remove(), which deadlocks. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5 de