Re: [PATCH 06/44] staging: spmi: hisi-spmi-controller: use le32 macros where needed

2020-08-12 Thread Mauro Carvalho Chehab
Em Wed, 12 Aug 2020 09:21:54 -0700 Joe Perches escreveu: > On Wed, 2020-08-12 at 17:56 +0200, Mauro Carvalho Chehab wrote: > > Instead of manually using bswap_32(), just use the > > le32 macros. > > Are you certain this code will now work on any endian cpu? > > Maybe just use __swab32

Re: [PATCH 06/44] staging: spmi: hisi-spmi-controller: use le32 macros where needed

2020-08-12 Thread Joe Perches
On Wed, 2020-08-12 at 17:56 +0200, Mauro Carvalho Chehab wrote: > Instead of manually using bswap_32(), just use the > le32 macros. Are you certain this code will now work on any endian cpu? Maybe just use __swab32 instead > diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c >

[PATCH 06/44] staging: spmi: hisi-spmi-controller: use le32 macros where needed

2020-08-12 Thread Mauro Carvalho Chehab
Instead of manually using bswap_32(), just use the le32 macros. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/hisi-spmi-controller.c | 20 +++ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c