Hi Christoph,
On Mon, Sep 02, 2019 at 05:47:37AM -0700, Christoph Hellwig wrote:
> On Mon, Sep 02, 2019 at 08:13:06PM +0800, Gao Xiang wrote:
> > Hi Christoph,
> >
> > On Mon, Sep 02, 2019 at 05:10:21AM -0700, Christoph Hellwig wrote:
> > > > {
> > > > - struct erofs_vnode *vi = ptr;
> > >
On Mon, Sep 02, 2019 at 08:13:06PM +0800, Gao Xiang wrote:
> Hi Christoph,
>
> On Mon, Sep 02, 2019 at 05:10:21AM -0700, Christoph Hellwig wrote:
> > > {
> > > - struct erofs_vnode *vi = ptr;
> > > -
> > > - inode_init_once(&vi->vfs_inode);
> > > + inode_init_once(&((struct erofs_inode *)ptr)->vf
Hi Christoph,
On Mon, Sep 02, 2019 at 05:10:21AM -0700, Christoph Hellwig wrote:
> > {
> > - struct erofs_vnode *vi = ptr;
> > -
> > - inode_init_once(&vi->vfs_inode);
> > + inode_init_once(&((struct erofs_inode *)ptr)->vfs_inode);
>
> Why doesn't this use EROFS_I? This looks a little odd
> {
> - struct erofs_vnode *vi = ptr;
> -
> - inode_init_once(&vi->vfs_inode);
> + inode_init_once(&((struct erofs_inode *)ptr)->vfs_inode);
Why doesn't this use EROFS_I? This looks a little odd.
___
devel mailing list
de...@linuxdriverproj
From: Gao Xiang
As Christoph suggested [1], "Why is this called vnode instead
of inode? That seems like a rather odd naming for a Linux
file system."
[1] https://lore.kernel.org/r/20190829101545.gc20...@infradead.org/
Reported-by: Christoph Hellwig
Signed-off-by: Gao Xiang
---
fs/erofs/data.
