Re: [PATCH 08/10] staging: fsl-mc: Fixed bug in dprc_probe() error path

2015-10-27 Thread Dan Carpenter
On Mon, Oct 26, 2015 at 10:49:19AM -0500, J. German Rivera wrote: > -error_cleanup_open: > +dprc_scan_container_error: > (void)dprc_close(mc_dev->mc_io, 0, mc_dev->mc_handle); The error label was better in the original code. A "goto error_cleanup_open", that tells you what the goto does.

[PATCH 08/10] staging: fsl-mc: Fixed bug in dprc_probe() error path

2015-10-26 Thread J. German Rivera
Destroy mc_io in error path in dprc_probe() only if the mc_io was created in this function. Minor refactoring in error labels. Signed-off-by: J. German Rivera --- drivers/staging/fsl-mc/bus/dprc-driver.c | 21 - 1 file changed, 16 insertions(+),