[PATCH 08/22] staging: erofs: kill CONFIG_EROFS_FS_IO_MAX_RETRIES

2019-07-28 Thread Gao Xiang
CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting and users have no idea about the change in behaviour. Let's remove the setting currently and fold it into code, turn it into a module parameter if it's really needed. Suggested-by: David Sterba Signed-off-by: Gao Xiang --- drivers/staging/

Re: [PATCH 08/22] staging: erofs: kill CONFIG_EROFS_FS_IO_MAX_RETRIES

2019-07-31 Thread Chao Yu
On 2019/7/29 14:51, Gao Xiang wrote: > CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting > and users have no idea about the change in behaviour. > > Let's remove the setting currently and fold it into code, > turn it into a module parameter if it's really needed. > > Suggested-by: David Ster

Re: [PATCH 08/22] staging: erofs: kill CONFIG_EROFS_FS_IO_MAX_RETRIES

2019-07-31 Thread Gao Xiang
Hi Chao, On 2019/7/31 15:05, Chao Yu wrote: > On 2019/7/29 14:51, Gao Xiang wrote: >> CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting >> and users have no idea about the change in behaviour. >> >> Let's remove the setting currently and fold it into code, >> turn it into a module parameter i

Re: [PATCH 08/22] staging: erofs: kill CONFIG_EROFS_FS_IO_MAX_RETRIES

2019-07-31 Thread Chao Yu
Hi Xiang, On 2019/7/31 15:11, Gao Xiang wrote: > Hi Chao, > > On 2019/7/31 15:05, Chao Yu wrote: >> On 2019/7/29 14:51, Gao Xiang wrote: >>> CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting >>> and users have no idea about the change in behaviour. >>> >>> Let's remove the setting currently

Re: [PATCH 08/22] staging: erofs: kill CONFIG_EROFS_FS_IO_MAX_RETRIES

2019-07-31 Thread Gao Xiang
On 2019/7/31 20:10, Chao Yu wrote: > Hi Xiang, > > On 2019/7/31 15:11, Gao Xiang wrote: >> Hi Chao, >> >> On 2019/7/31 15:05, Chao Yu wrote: >>> On 2019/7/29 14:51, Gao Xiang wrote: CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting and users have no idea about the change in behav