On 2015년 07월 30일 05:54, Greg KH wrote:
On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote:
This patch lets preprocessor conditionals (#ifdef) related to
WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out
the entire functions is preferred rather than portions of functio
On 2015년 07월 30일 06:29, Greg KH wrote:
On Thu, Jul 30, 2015 at 12:14:08AM +0300, Dan Carpenter wrote:
On Wed, Jul 29, 2015 at 01:54:54PM -0700, Greg KH wrote:
On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote:
/**
* Disable power sequencer
**/
- if
On 2015년 07월 30일 06:14, Dan Carpenter wrote:
On Wed, Jul 29, 2015 at 01:54:54PM -0700, Greg KH wrote:
On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote:
/**
* Disable power sequencer
**/
- if (!sdio_read_reg(WILC_MISC, ®)) {
+ if(!sdio_read_reg
Got it, thanks.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Jul 30, 2015 at 12:14:08AM +0300, Dan Carpenter wrote:
> On Wed, Jul 29, 2015 at 01:54:54PM -0700, Greg KH wrote:
> > On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote:
> > > /**
> > >* Disable power sequencer
> > >**/
> > > - if (!sdio_read_reg(WILC_MISC, ®)) {
> > >
On Wed, Jul 29, 2015 at 01:54:54PM -0700, Greg KH wrote:
> On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote:
> > /**
> > * Disable power sequencer
> > **/
> > - if (!sdio_read_reg(WILC_MISC, ®)) {
> > + if(!sdio_read_reg(WILC_MISC, ®)) {
>
I noticed this style chang
On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote:
> This patch lets preprocessor conditionals (#ifdef) related to
> WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out
> the entire functions is preferred rather than portions of functions or
> expressions becausue doing so
This patch lets preprocessor conditionals (#ifdef) related to
WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out
the entire functions is preferred rather than portions of functions or
expressions becausue doing so makes code harder to read.
Signed-off-by: Tony Cho
---
drivers/