I'm sorry this one doesn't make any sense. ??? Take the weekend off.
Have your co-workers review the patch on Monday. Then resend.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailm
Replaced "cleanups" in the struct parser_init_guts with err_rgn,
err_ctx, and out_rgn. The purpose is to remove redundant code and
have proper error handling. Put "goto out_rgn" on lin 108 because
there was no "out_ctx".
Signed-off-by: Jeffrey Brown
---
drivers/staging/unisys/visorchipset/parser
On Fri, Nov 14, 2014 at 05:43:24PM +0300, Dan Carpenter wrote:
> > @@ -90,7 +88,6 @@ parser_init_guts(u64 addr, u32 bytes, BOOL is_local,
> >__func__,
> >(unsigned long long)addr, (ulong)bytes);
> > rc = NULL;
> > -
Better, but it still needs more work.
On Fri, Nov 14, 2014 at 07:41:28AM -0500, Jeffrey Brown wrote:
> Replaced "cleanups" in the struct parser_init_guts with err_rgn,
> err_ctx, and out_rgn. The purpose is to remove redundant code and
> have proper error handling
>
> Signed-off-by: Jeffrey Brown
Replaced "cleanups" in the struct parser_init_guts with err_rgn,
err_ctx, and out_rgn. The purpose is to remove redundant code and
have proper error handling
Signed-off-by: Jeffrey Brown
---
drivers/staging/unisys/visorchipset/parser.c | 43 +++--
1 files changed, 19 insert
