RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

2018-09-29 Thread Y.b. Lu
g; Richard Cochran ; > David S . Miller ; Ioana Ciocoi Radulescu > ; Greg Kroah-Hartman > > Subject: RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/ > > Hi Andrew, > > Thanks a lot for your comments. > Please see my comments inline. > > Best regards, >

RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

2018-09-28 Thread Y.b. Lu
gt; ; Greg Kroah-Hartman > > Subject: Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/ > > > > struct dprtc_cmd_get_irq - Putting pad at the beginning of a struct > > > seems very odd. And it is not the only example. > > > > [Y.b. Lu] This

RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

2018-09-28 Thread Y.b. Lu
; Greg Kroah-Hartman > > Subject: RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/ > > > -Original Message- > > From: Y.b. Lu > > Sent: Friday, September 28, 2018 11:04 AM > > To: Andrew Lunn > > Cc: linux-ker...@vger.kernel.org; de.

Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

2018-09-28 Thread Andrew Lunn
> > struct dprtc_cmd_get_irq - Putting pad at the beginning of a struct seems > > very > > odd. And it is not the only example. > > [Y.b. Lu] This should depended on MC firmware and APIs I think. Once the MC > improves this, the APIs could be updated to fix this. That is going to be hard to

Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

2018-09-28 Thread Richard Cochran
On Fri, Sep 28, 2018 at 10:20:55AM +, Ioana Ciocoi Radulescu wrote: > Generally speaking, I think it's better to remove unused code from the current > driver and re-add it along with the feature actually using it. +1 Thanks, Richard ___ devel

RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

2018-09-28 Thread Y.b. Lu
uosl.org; > net...@vger.kernel.org; Richard Cochran ; > David S . Miller ; Ioana Ciocoi Radulescu > ; Greg Kroah-Hartman > > Subject: Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/ > > On Thu, Sep 27, 2018 at 07:12:27PM +0800, Yangbo Lu wrote: > > This patch is to m

RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

2018-09-28 Thread Ioana Ciocoi Radulescu
oah-Hartman > > Subject: RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/ > > Hi Andrew, > > Thanks a lot for your comments. > Please see my comments inline. > > Best regards, > Yangbo Lu > > > -Original Message- > > From: An

Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

2018-09-27 Thread Andrew Lunn
On Thu, Sep 27, 2018 at 07:12:27PM +0800, Yangbo Lu wrote: > This patch is to move DPAA2 PTP driver out of staging/ > since the dpaa2-eth had been moved out. > > Signed-off-by: Yangbo Lu > --- > drivers/net/ethernet/freescale/Kconfig |9 + >

[PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

2018-09-27 Thread Yangbo Lu
This patch is to move DPAA2 PTP driver out of staging/ since the dpaa2-eth had been moved out. Signed-off-by: Yangbo Lu --- drivers/net/ethernet/freescale/Kconfig |9 + drivers/net/ethernet/freescale/dpaa2/Kconfig | 15 +++