Re: [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain

2017-07-27 Thread Rui Miguel Silva
Hi, On Wed, Jul 26, 2017 at 08:32:08PM +0200, Pavel Machek wrote: > Hi! > > > On Tue, Jul 25, 2017 at 02:30:31PM +0200, Johan Hovold wrote: > > > [ +CC: Rui and Greg ] > > > > Thanks Johan. I only got this because of you. > > > > > return ret; > > > > } > > > > > > And while it's fine

Re: [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain

2017-07-26 Thread Pavel Machek
Hi! > On Tue, Jul 25, 2017 at 02:30:31PM +0200, Johan Hovold wrote: > > [ +CC: Rui and Greg ] > > Thanks Johan. I only got this because of you. > > > return ret; > > > } > > > > And while it's fine to take this through linux-media, it would still be > > good to keep the maintainers on CC. >

Re: [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain

2017-07-26 Thread Rui Miguel Silva
Hi, On Tue, Jul 25, 2017 at 02:30:31PM +0200, Johan Hovold wrote: > [ +CC: Rui and Greg ] Thanks Johan. I only got this because of you. > > On Tue, Jul 18, 2017 at 09:41:06PM +0300, Sakari Ailus wrote: > > Memory for struct v4l2_flash_config is allocated in > > gb_lights_light_v4l2_register()

Re: [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain

2017-07-25 Thread Johan Hovold
[ +CC: Rui and Greg ] On Tue, Jul 18, 2017 at 09:41:06PM +0300, Sakari Ailus wrote: > Memory for struct v4l2_flash_config is allocated in > gb_lights_light_v4l2_register() for no gain and yet the allocated memory is > leaked; the struct isn't used outside the function. Fix this. > >