Re: [PATCH 1/2] staging: greybus: vibrator: use proper API for vibrator devices

2021-01-29 Thread Greg Kroah-Hartman
On Wed, Jan 06, 2021 at 01:08:15PM +0100, Johan Hovold wrote: > On Wed, Jan 06, 2021 at 01:04:04PM +0100, Johan Hovold wrote: > > On Tue, Jan 05, 2021 at 04:19:02PM +0100, Greg Kroah-Hartman wrote: > > > The correct user/kernel api for vibrator devices is the Input rumble > > > api, not a random

Re: [PATCH 1/2] staging: greybus: vibrator: use proper API for vibrator devices

2021-01-06 Thread Johan Hovold
On Wed, Jan 06, 2021 at 01:04:04PM +0100, Johan Hovold wrote: > On Tue, Jan 05, 2021 at 04:19:02PM +0100, Greg Kroah-Hartman wrote: > > The correct user/kernel api for vibrator devices is the Input rumble > > api, not a random sysfs file like the greybus vibrator driver currently > > uses. > > >

Re: [PATCH 1/2] staging: greybus: vibrator: use proper API for vibrator devices

2021-01-06 Thread Johan Hovold
On Tue, Jan 05, 2021 at 04:19:02PM +0100, Greg Kroah-Hartman wrote: > The correct user/kernel api for vibrator devices is the Input rumble > api, not a random sysfs file like the greybus vibrator driver currently > uses. > > Add support for the correct input api to the vibrator driver so that it

Re: [PATCH 1/2] staging: greybus: vibrator: use proper API for vibrator devices

2021-01-05 Thread kernel test robot
Hi Greg, I love your patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/staging-greybus-vibrator-use-proper-API-for-vibrator-devices/20210105-232001 base:

[PATCH 1/2] staging: greybus: vibrator: use proper API for vibrator devices

2021-01-05 Thread Greg Kroah-Hartman
The correct user/kernel api for vibrator devices is the Input rumble api, not a random sysfs file like the greybus vibrator driver currently uses. Add support for the correct input api to the vibrator driver so that it hooks up to the kernel and userspace correctly. Cc: Johan Hovold Cc: Alex