Re: [PATCH 1/2] staging: iio_simple_dummy: fix init

2015-05-27 Thread Dan Carpenter
On Wed, May 27, 2015 at 01:19:57AM +0300, Vladimirs Ambrosovs wrote: @@ -685,15 +684,14 @@ static int iio_dummy_remove(int index) /* Buffered capture related cleanup */ iio_simple_dummy_unconfigure_buffer(indio_dev); - ret = iio_simple_dummy_events_unregister(indio_dev); -

Re: [PATCH 1/2] staging: iio_simple_dummy: fix init

2015-05-27 Thread Vladimirs Ambrosovs
On Wed, May 27, 2015 at 09:21:28AM +0300, Daniel Baluta wrote: Hi, On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs rodriguez.twis...@gmail.com wrote: This patch fixes the init function for the iio_simple_dummy driver. The main issues were absence of kfree for the allocated array, and

Re: [PATCH 1/2] staging: iio_simple_dummy: fix init

2015-05-27 Thread Dan Carpenter
On Wed, May 27, 2015 at 08:24:18PM +0300, Vladimirs Ambrosovs wrote: On Wed, May 27, 2015 at 09:21:28AM +0300, Daniel Baluta wrote: Hi, On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs rodriguez.twis...@gmail.com wrote: This patch fixes the init function for the iio_simple_dummy

Re: [PATCH 1/2] staging: iio_simple_dummy: fix init

2015-05-27 Thread Daniel Baluta
Hi, On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs rodriguez.twis...@gmail.com wrote: This patch fixes the init function for the iio_simple_dummy driver. The main issues were absence of kfree for the allocated array, and no devices being removed in case the probe function fails, running

Re: [PATCH 1/2] staging: iio_simple_dummy: fix init

2015-05-27 Thread Daniel Baluta
On Wed, May 27, 2015 at 8:29 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Wed, May 27, 2015 at 08:24:18PM +0300, Vladimirs Ambrosovs wrote: On Wed, May 27, 2015 at 09:21:28AM +0300, Daniel Baluta wrote: Hi, On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs

[PATCH 1/2] staging: iio_simple_dummy: fix init

2015-05-26 Thread Vladimirs Ambrosovs
This patch fixes the init function for the iio_simple_dummy driver. The main issues were absence of kfree for the allocated array, and no devices being removed in case the probe function fails, running in a loop. The iio_dummy_remove function was also changed: * The return value was