Re: [PATCH 1/2] staging: vt6656: remove unneeded variable: ret

2020-03-24 Thread Quentin Deslandes
On 03/23/20 23:45:44, John B. Wyatt IV wrote: > vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD); This function, and all the functions called in vnt_radio_power_on() returns a value, why don't you catch it and act accordingly (forward error code for example) instead of silencing

[PATCH 1/2] staging: vt6656: remove unneeded variable: ret

2020-03-24 Thread John B. Wyatt IV
Remove unneeded variable ret; replace with 0 for the return value. Update function documentation (comment) on the return status as suggested by Julia Lawall . Issue reported by coccinelle (coccicheck). Signed-off-by: John B. Wyatt IV --- drivers/staging/vt6656/card.c | 6 ++ 1 file