>Yeah. That is often the fastest way to fix all the checkpatch warnings.
>
>Checkpatch warnings are pretty mechanical. Just send like 100 patches
>at a time until everything is fixed. Don't overthink. Say your patch
>breaks the alignment then you have to fix that, but otherwise only fix
>one th
Yeah. That is often the fastest way to fix all the checkpatch warnings.
Checkpatch warnings are pretty mechanical. Just send like 100 patches
at a time until everything is fixed. Don't overthink. Say your patch
breaks the alignment then you have to fix that, but otherwise only fix
one thing at
I suspect you're over-thinking it. The maintainers appear to be
reacting to the different types of style changes - "checkpatch
cleanups" is an awfully broad commit message. I'd suggest breaking
this patch (and any others like it) into two pieces; one with
whitespace cleanups, and one with the "==
>On Thu, Oct 29, 2015 at 07:28:21PM -0400, James Simmons wrote:
>> With nidstring now having the latest fixes we can
>> now clean up all the remaining checkpatch errors
>> for nidstring.c.
>
>Please be specific as to exactly what you changed, and break it up into
>one-patch-per-thing. And no, "fix
On Thu, Oct 29, 2015 at 07:28:21PM -0400, James Simmons wrote:
> With nidstring now having the latest fixes we can
> now clean up all the remaining checkpatch errors
> for nidstring.c.
Please be specific as to exactly what you changed, and break it up into
one-patch-per-thing. And no, "fix all ch
On Thu, Oct 29, 2015 at 07:28:21PM -0400, James Simmons wrote:
> With nidstring now having the latest fixes we can
> now clean up all the remaining checkpatch errors
> for nidstring.c.
>
> Signed-off-by: James Simmons
> ---
You are doing different types of changes in this patch. Please split
the
With nidstring now having the latest fixes we can
now clean up all the remaining checkpatch errors
for nidstring.c.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/lnet/nidstrings.c | 80 ++---
1 files changed, 44 insertions(+), 36 deletions(-)
diff --git a/dr
