Re: [PATCH 1/3] staging: pi433: Style fix - align block comments

Hi Dan, when I started with the RFM69CW about two years ago (at the beginning not as a driver, but everything within the applicaton) I kind of automatically produced a list of all registers of the chip (most probably by importing and reorganizing the datasheet in Excel). Everytime I need to

Re: [PATCH 1/3] staging: pi433: Style fix - align block comments

On Sat, Jul 22, 2017 at 03:50:50PM +1200, Derek Robson wrote: > + * // RegOsc1 > + * #define OSC1_RCCAL_START 0x80 > + * #define OSC1_RCCAL_DONE 0x40 > + * Why do we have all these commented out defines? regards, dan carpenter

Re: [PATCH 1/3] staging: pi433: Style fix - align block comments

Reviewed-by: Marcus Wolf Thanks for your work, Derek! > Derek Robson hat am 22. Juli 2017 um 05:50 geschrieben: > > > Fixed the alignment of block comments > Found using checkpatch > > Signed-off-by: Derek Robson > --- >

[PATCH 1/3] staging: pi433: Style fix - align block comments

Fixed the alignment of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/pi433/pi433_if.c | 38 +++-- drivers/staging/pi433/rf69.c | 10 +- drivers/staging/pi433/rf69_registers.h | 280 - 3