Re: [PATCH 1/3] staging: vt6656: Remove the local variable "array"

2020-04-25 Thread Oscar Carter
On Sat, Apr 25, 2020 at 05:50:39AM -0700, Joe Perches wrote: > On Sat, 2020-04-25 at 14:38 +0200, Oscar Carter wrote: > > Remove the local variable "array" and all the memcpy function calls > > because this copy operation from different arrays to this variable is > > unnecessary. > > You might writ

Re: [PATCH 1/3] staging: vt6656: Remove the local variable "array"

2020-04-25 Thread Joe Perches
On Sat, 2020-04-25 at 14:38 +0200, Oscar Carter wrote: > Remove the local variable "array" and all the memcpy function calls > because this copy operation from different arrays to this variable is > unnecessary. You might write here that vnt_control_out already does a kmemdup copy of its const cha

[PATCH 1/3] staging: vt6656: Remove the local variable "array"

2020-04-25 Thread Oscar Carter
Remove the local variable "array" and all the memcpy function calls because this copy operation from different arrays to this variable is unnecessary. The same result can be achieved using the arrays directly. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/rf.c | 21 +---