Re: [PATCH 1/3] usb: gadget: udc: Avoid tasklet passing a global

2020-07-31 Thread Felipe Balbi
Hi, Kees Cook writes: > There's no reason for the tasklet callback to set an argument since it > always uses a global. Instead, use the global directly, in preparation > for converting the tasklet subsystem to modern callback conventions. > > Signed-off-by: Kees Cook looks okay to me. Acked-by

Re: [PATCH 1/3] usb: gadget: udc: Avoid tasklet passing a global

2020-07-16 Thread Kees Cook
On Thu, Jul 16, 2020 at 09:28:23AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 15, 2020 at 08:08:45PM -0700, Kees Cook wrote: > > There's no reason for the tasklet callback to set an argument since it > > always uses a global. Instead, use the global directly, in preparation > > for converting t

Re: [PATCH 1/3] usb: gadget: udc: Avoid tasklet passing a global

2020-07-16 Thread Greg Kroah-Hartman
On Wed, Jul 15, 2020 at 08:08:45PM -0700, Kees Cook wrote: > There's no reason for the tasklet callback to set an argument since it > always uses a global. Instead, use the global directly, in preparation > for converting the tasklet subsystem to modern callback conventions. > > Signed-off-by: Kee

[PATCH 1/3] usb: gadget: udc: Avoid tasklet passing a global

2020-07-15 Thread Kees Cook
There's no reason for the tasklet callback to set an argument since it always uses a global. Instead, use the global directly, in preparation for converting the tasklet subsystem to modern callback conventions. Signed-off-by: Kees Cook --- drivers/usb/gadget/udc/snps_udc_core.c | 6 ++ 1 fil