Re: [PATCH 1/4] staging: iio: ad7150: organize registers definition

2019-05-05 Thread Jonathan Cameron
On Sat, 4 May 2019 13:13:55 +0300 Alexandru Ardelean wrote: > On Sat, May 4, 2019 at 1:25 AM Melissa Wen wrote: > > > > Use the suffix REG to make the register addresses clear > > and indentation to highlight field names. > > > > I'm inclined to say that this change is a bit too much noise

Re: [PATCH 1/4] staging: iio: ad7150: organize registers definition

2019-05-04 Thread Alexandru Ardelean
On Sat, May 4, 2019 at 1:25 AM Melissa Wen wrote: > > Use the suffix REG to make the register addresses clear > and indentation to highlight field names. > I'm inclined to say that this change is a bit too much noise versus added value. While the REG suffix does make sense (generally), since it

[PATCH 1/4] staging: iio: ad7150: organize registers definition

2019-05-03 Thread Melissa Wen
Use the suffix REG to make the register addresses clear and indentation to highlight field names. Signed-off-by: Melissa Wen --- drivers/staging/iio/cdc/ad7150.c | 75 1 file changed, 37 insertions(+), 38 deletions(-) diff --git