Re: [PATCH 1/4] staging: unisys: remove do{} while(0) in channel.h

2014-08-18 Thread Dan Carpenter
On Mon, Aug 18, 2014 at 07:19:53PM +0300, Dan Carpenter wrote: > On Mon, Aug 18, 2014 at 09:21:43AM -0400, Benjamin Romer wrote: > > #define CHANNEL_GUID_MISMATCH(chType, chName, field, expected, actual, > > fil, \ > > lin, logCtx) \ > > -

Re: [PATCH 1/4] staging: unisys: remove do{} while(0) in channel.h

2014-08-18 Thread Dan Carpenter
On Mon, Aug 18, 2014 at 09:21:43AM -0400, Benjamin Romer wrote: > #define CHANNEL_GUID_MISMATCH(chType, chName, field, expected, actual, fil, \ > lin, logCtx) \ > - do {\ > +

[PATCH 1/4] staging: unisys: remove do{} while(0) in channel.h

2014-08-18 Thread Benjamin Romer
The CHANNEL_*_MISMATCH error message macros should not be inside of do blocks. Signed-off-by: Benjamin Romer --- .../staging/unisys/common-spar/include/channels/channel.h| 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys/common-spar/includ