Re: [PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook

2017-12-01 Thread Boris Brezillon
On Thu, 30 Nov 2017 23:02:46 +0100 Miquel RAYNAL wrote: > > > diff --git a/drivers/mtd/nand/nand_base.c > > > b/drivers/mtd/nand/nand_base.c index 630048f5abdc..4d1f2bda6095 > > > 100644 --- a/drivers/mtd/nand/nand_base.c > > > +++ b/drivers/mtd/nand/nand_base.c

Re: [PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook

2017-11-30 Thread Masahiro Yamada
2017-12-01 7:02 GMT+09:00 Miquel RAYNAL : >> > diff --git a/drivers/mtd/nand/nand_base.c >> > b/drivers/mtd/nand/nand_base.c index 630048f5abdc..4d1f2bda6095 >> > 100644 --- a/drivers/mtd/nand/nand_base.c >> > +++ b/drivers/mtd/nand/nand_base.c >> > @@ -3077,7

Re: [PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook

2017-11-30 Thread Miquel RAYNAL
> > diff --git a/drivers/mtd/nand/nand_base.c > > b/drivers/mtd/nand/nand_base.c index 630048f5abdc..4d1f2bda6095 > > 100644 --- a/drivers/mtd/nand/nand_base.c > > +++ b/drivers/mtd/nand/nand_base.c > > @@ -3077,7 +3077,7 @@ int nand_erase_nand(struct mtd_info *mtd, > > struct erase_info *instr,

Re: [PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook

2017-11-30 Thread Boris Brezillon
On Thu, 30 Nov 2017 18:01:28 +0100 Miquel Raynal wrote: > Avoid using specific defined values for checking returned status of the > ->erase() hook. Instead, use usual negative error values on failure, > zero otherwise. > > Signed-off-by: Miquel Raynal

[PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook

2017-11-30 Thread Miquel Raynal
Avoid using specific defined values for checking returned status of the ->erase() hook. Instead, use usual negative error values on failure, zero otherwise. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/denali.c| 2 +- drivers/mtd/nand/docg4.c | 7