Re: [PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-13 Thread Dan Carpenter
On Thu, Dec 13, 2018 at 02:15:59PM +, christian.gr...@microchip.com wrote: > Sounds reasonable. But, problem here is that we want the > process of how channels are linked to be independent from the  > component that is being used. That's when things start to > become complicated.  I'm not

Re: [PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-13 Thread Christian.Gromm
On Do, 2018-12-13 at 15:38 +0300, Dan Carpenter wrote: > On Wed, Dec 12, 2018 at 03:31:13PM +, Christian.Gromm@microchip.c > om wrote: > > > > An additional field is added to the configuration parameter, > > which is provided by user space. > > This seemed to be less painful than adding a new

Re: [PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-13 Thread Christian.Gromm
On Do, 2018-12-13 at 15:16 +0300, Dan Carpenter wrote: > On Wed, Dec 12, 2018 at 01:15:26PM +0100, Christian Gromm wrote: > > > > @@ -571,6 +600,40 @@ static int audio_probe_channel(struct > > most_interface *iface, int channel_id, > >   return -EINVAL; > >   } > >   > > + ret =

Re: [PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-13 Thread Dan Carpenter
On Thu, Dec 13, 2018 at 03:38:03PM +0300, Dan Carpenter wrote: > On Wed, Dec 12, 2018 at 03:31:13PM +, christian.gr...@microchip.com wrote: > > An additional field is added to the configuration parameter, > > which is provided by user space. > > This seemed to be less painful than adding a new

Re: [PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-13 Thread Dan Carpenter
On Wed, Dec 12, 2018 at 03:31:13PM +, christian.gr...@microchip.com wrote: > An additional field is added to the configuration parameter, > which is provided by user space. > This seemed to be less painful than adding a new sysfs > file and make the configuration even more complicated.  I

Re: [PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-13 Thread Dan Carpenter
On Wed, Dec 12, 2018 at 01:15:26PM +0100, Christian Gromm wrote: > @@ -571,6 +600,40 @@ static int audio_probe_channel(struct most_interface > *iface, int channel_id, > return -EINVAL; > } > > + ret = split_arg_list(arg_list, _name, _num, _res, > +

Re: [PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-13 Thread Dan Carpenter
On Wed, Dec 12, 2018 at 03:31:13PM +, christian.gr...@microchip.com wrote: > On Mi, 2018-12-12 at 17:21 +0300, Dan Carpenter wrote: > > On Wed, Dec 12, 2018 at 01:15:26PM +0100, Christian Gromm wrote: > > > > > > This patch avoids that a sound card is created and registered with > > > ALSA >

Re: [PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-12 Thread Christian.Gromm
On Mi, 2018-12-12 at 17:21 +0300, Dan Carpenter wrote: > On Wed, Dec 12, 2018 at 01:15:26PM +0100, Christian Gromm wrote: > > > > This patch avoids that a sound card is created and registered with > > ALSA > > every time a channel is being linked. Instead the channels are > > hooked on > > the

Re: [PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-12 Thread Dan Carpenter
On Wed, Dec 12, 2018 at 01:15:26PM +0100, Christian Gromm wrote: > This patch avoids that a sound card is created and registered with ALSA > every time a channel is being linked. Instead the channels are hooked on > the same card, which is registered not until the final link has been added > to

[PATCH 1/6] staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-12 Thread Christian Gromm
This patch avoids that a sound card is created and registered with ALSA every time a channel is being linked. Instead the channels are hooked on the same card, which is registered not until the final link has been added to the component. Signed-off-by: Christian Gromm ---