Re: [PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling

2013-09-24 Thread Jürgen Beisert
Hi Lothar, On Monday 23 September 2013 17:30:18 Lothar Waßmann wrote: [...] @@ -928,6 +931,9 @@ static int mxs_lradc_probe(struct platform_device *pdev) if (IS_ERR(lradc-base)) return PTR_ERR(lradc-base); + lradc-clk = devm_clk_get(pdev-dev, NULL); +

Re: [PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling

2013-09-24 Thread Jürgen Beisert
Hi Fabio, On Monday 23 September 2013 17:13:03 Fabio Estevam wrote: On 09/23/2013 11:36 AM, Juergen Beisert wrote: + lradc-clk = devm_clk_get(pdev-dev, NULL); + clk_prepare_enable(lradc-clk); clk_prepare_enable() may fail, so better check its return value. Thanks for the comment.

[PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling

2013-09-23 Thread Juergen Beisert
The delay units inside the LRADC depend on the presence of a 2 kHz clock. This change enables the clock to be able to use the delay unit for the touchscreen part of the driver. Signed-off-by: Juergen Beisert j...@pengutronix.de --- arch/arm/boot/dts/imx23.dtsi| 1 +

Re: [PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling

2013-09-23 Thread Fabio Estevam
On 09/23/2013 11:36 AM, Juergen Beisert wrote: + lradc-clk = devm_clk_get(pdev-dev, NULL); + clk_prepare_enable(lradc-clk); clk_prepare_enable() may fail, so better check its return value. ___ devel mailing list

Re: [PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling

2013-09-23 Thread Lothar Waßmann
Hi, Juergen Beisert writes: diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c index a08c173..00b61ac 100644 --- a/drivers/staging/iio/adc/mxs-lradc.c +++ b/drivers/staging/iio/adc/mxs-lradc.c @@ -35,6 +35,7 @@ #include linux/completion.h #include