Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

2014-08-11 Thread Julia Lawall
On Mon, 11 Aug 2014, Joe Perches wrote: > On Mon, 2014-08-11 at 16:27 +0530, Srikrishan Malik wrote: > > On Thu, Aug 07, 2014 at 09:35:43AM -0700, Joe Perches wrote: > > > On Thu, 2014-08-07 at 19:01 +0300, Dan Carpenter wrote: > > > > On Thu, Aug 07, 2014 at 09:01:36PM +0530, Srikrishan Malik w

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

2014-08-11 Thread Dan Carpenter
On Mon, Aug 11, 2014 at 04:27:06PM +0530, Srikrishan Malik wrote: > This patch set is aimed at removing checkpatch issues from files in > lustre/lustre/mdc. > > Is it ok if I just fix those in this set and post another patch set > to take care of other issues identified in review? checkpatch fixe

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

2014-08-11 Thread Joe Perches
On Mon, 2014-08-11 at 16:27 +0530, Srikrishan Malik wrote: > On Thu, Aug 07, 2014 at 09:35:43AM -0700, Joe Perches wrote: > > On Thu, 2014-08-07 at 19:01 +0300, Dan Carpenter wrote: > > > On Thu, Aug 07, 2014 at 09:01:36PM +0530, Srikrishan Malik wrote: > > > > On Wed, Aug 06, 2014 at 11:18:13PM +0

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

2014-08-11 Thread Srikrishan Malik
On Thu, Aug 07, 2014 at 09:35:43AM -0700, Joe Perches wrote: > On Thu, 2014-08-07 at 19:01 +0300, Dan Carpenter wrote: > > On Thu, Aug 07, 2014 at 09:01:36PM +0530, Srikrishan Malik wrote: > > > On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote: > > > > That looks silly before and after

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

2014-08-07 Thread Joe Perches
On Thu, 2014-08-07 at 19:01 +0300, Dan Carpenter wrote: > On Thu, Aug 07, 2014 at 09:01:36PM +0530, Srikrishan Malik wrote: > > On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote: > > > That looks silly before and after. Everything is indented in a funny > > > way. > > > > Is this bett

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

2014-08-07 Thread Dan Carpenter
On Thu, Aug 07, 2014 at 09:01:36PM +0530, Srikrishan Malik wrote: > On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote: > > That looks silly before and after. Everything is indented in a funny > > way. > > Is this better: > > static const ldlm_policy_data_t lookup_policy = { >

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

2014-08-07 Thread Srikrishan Malik
On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote: > On Wed, Aug 06, 2014 at 10:43:00PM +0530, Srikrishan Malik wrote: > > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c > > b/drivers/staging/lustre/lustre/mdc/mdc_locks.c > > index c03d77c9c5b8..09209171b50c 100644 > > ---

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

2014-08-06 Thread Dan Carpenter
On Wed, Aug 06, 2014 at 10:43:00PM +0530, Srikrishan Malik wrote: > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c > b/drivers/staging/lustre/lustre/mdc/mdc_locks.c > index c03d77c9c5b8..09209171b50c 100644 > --- a/drivers/staging/lustre/lustre/mdc/mdc_locks.c > +++ b/drivers/staging/l

[PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

2014-08-06 Thread Srikrishan Malik
Fixes the following checkpatch error: ERROR: that open brace { should be on the previous line Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 12 ++-- drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +-- drivers/staging/lustre/lustre/mdc/mdc_re