Re: [PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

2014-02-16 Thread Larry Finger
On 02/15/2014 02:41 PM, Greg KH wrote: On Sat, Feb 15, 2014 at 12:38:11PM -0800, Greg KH wrote: I've applied this series up to here. Nevermind, the others applied, so I've merged them, just not this patch. I have split this patch into two parts that I will send tomorrow. The first one just

Re: [PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

2014-02-15 Thread Greg KH
On Sat, Feb 15, 2014 at 12:38:11PM -0800, Greg KH wrote: > I've applied this series up to here. Nevermind, the others applied, so I've merged them, just not this patch. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverd

Re: [PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

2014-02-15 Thread Greg KH
On Fri, Feb 14, 2014 at 04:54:14PM -0600, Larry Finger wrote: > This wrapper returned the result of mutex_lock_interruptible(); however, > none of the callers checked the returned value. Then why is the code logic changing? > > As a result of a gcc upgrade to version 4.8.1, two false unitialized

Re: [PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

2014-02-15 Thread Larry Finger
On 02/15/2014 04:41 AM, Dan Carpenter wrote: On Fri, Feb 14, 2014 at 04:54:14PM -0600, Larry Finger wrote: diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c index 1fa5370..d5f6a32 100644 --- a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c

Re: [PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

2014-02-15 Thread Dan Carpenter
On Fri, Feb 14, 2014 at 04:54:14PM -0600, Larry Finger wrote: > diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c > b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c > index 1fa5370..d5f6a32 100644 > --- a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c > +++ b/drivers/staging/rtl8188eu/hal/u

[PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

2014-02-14 Thread Larry Finger
This wrapper returned the result of mutex_lock_interruptible(); however, none of the callers checked the returned value. As a result of a gcc upgrade to version 4.8.1, two false unitialized variable warnings appeared. To silence the warnings, they are initialized to 0. Signed-off-by: Larry Finger