Re: [PATCH 11/11] staging: unisys: small bug parser.c

2014-11-26 Thread Greg KH
On Thu, Nov 13, 2014 at 09:56:39AM -0500, Jeffrey Brown wrote: > Fixed small bug in parser.c by removing "cleanups:" in parser_init > _guts struct. Replaced it with proper error handling code > and removed the instances of rc = NULL in the code. rc = NULL is > redudant > > Signed-off-by: Jeffrey

Re: [PATCH 11/11] staging: unisys: small bug parser.c

2014-11-14 Thread Dan Carpenter
On Fri, Nov 14, 2014 at 01:48:32PM +0300, Dan Carpenter wrote: > out_rgn: > if (rgn) > visor_memregion_destroy(rgn); Oops. We're supposed to increase controlvm_payload_bytes_buffered on the success path: controlvm_payload_bytes_buffered += ctx->param_bytes; > >

Re: [PATCH 11/11] staging: unisys: small bug parser.c

2014-11-14 Thread Dan Carpenter
I have added Markus to the CC list because I want to describe how "extra" if statements make the code more readable towards the end of this function. This patch needs more work. The subject shouldn't be "11/11" because it's not part of a series. Just say: "[PATCH] staging: unisys: small bug in p

[PATCH 11/11] staging: unisys: small bug parser.c

2014-11-13 Thread Jeffrey Brown
Fixed small bug in parser.c by removing "cleanups:" in parser_init _guts struct. Replaced it with proper error handling code and removed the instances of rc = NULL in the code. rc = NULL is redudant Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/parser.c | 46 ++