Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-02 Thread Daniel Vetter
O n Tue, Oct 2, 2018 at 11:25 AM Hans de Goede wrote: > > Hi, > > On 02-10-18 00:01, Daniel Vetter wrote: > > On Mon, Oct 1, 2018 at 11:14 PM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 01-10-18 18:52, Daniel Vetter wrote: > >>> On Mon, Oct 01, 2018 at 11:37:29AM +0200, Hans de Goede wrote: >

Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-02 Thread Hans de Goede
Hi, On 02-10-18 00:01, Daniel Vetter wrote: On Mon, Oct 1, 2018 at 11:14 PM Hans de Goede wrote: Hi, On 01-10-18 18:52, Daniel Vetter wrote: On Mon, Oct 01, 2018 at 11:37:29AM +0200, Hans de Goede wrote: Hi, On 01-10-18 09:53, Daniel Vetter wrote: On Wed, Sep 26, 2018 at 09:42:02PM +0200

Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-01 Thread Daniel Vetter
On Mon, Oct 1, 2018 at 11:14 PM Hans de Goede wrote: > > Hi, > > On 01-10-18 18:52, Daniel Vetter wrote: > > On Mon, Oct 01, 2018 at 11:37:29AM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 01-10-18 09:53, Daniel Vetter wrote: > >>> On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede wrote

Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-01 Thread Hans de Goede
Hi, On 01-10-18 18:52, Daniel Vetter wrote: On Mon, Oct 01, 2018 at 11:37:29AM +0200, Hans de Goede wrote: Hi, On 01-10-18 09:53, Daniel Vetter wrote: On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede wrote: Atomic modesetting does not use the traditional dpms call backs, instead we sh

Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-01 Thread Daniel Vetter
On Mon, Oct 01, 2018 at 11:37:29AM +0200, Hans de Goede wrote: > Hi, > > On 01-10-18 09:53, Daniel Vetter wrote: > > On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede wrote: > > > Atomic modesetting does not use the traditional dpms call backs, instead > > > we should check crtc_state->activ

Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-01 Thread Hans de Goede
Hi, On 01-10-18 09:53, Daniel Vetter wrote: On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede wrote: Atomic modesetting does not use the traditional dpms call backs, instead we should check crtc_state->active. Signed-off-by: Hans de Goede Are you sure this does what you want it to do?

Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-01 Thread Daniel Vetter
On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede wrote: > Atomic modesetting does not use the traditional dpms call backs, instead > we should check crtc_state->active. > > Signed-off-by: Hans de Goede Are you sure this does what you want it to do? Atomic helpers fully shut down the scree

[PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-09-26 Thread Hans de Goede
Atomic modesetting does not use the traditional dpms call backs, instead we should check crtc_state->active. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_drv.h | 1 - drivers/staging/vboxvideo/vbox_mode.c | 28 ++- 2 files changed, 2 insertions(+), 27