Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-16 Thread Todd Poynor
On Sun, Jul 15, 2018 at 12:41 PM, Greg Kroah-Hartman wrote: > On Sun, Jul 15, 2018 at 11:15:26AM -0700, Todd Poynor wrote: >> On Sun, Jul 15, 2018 at 3:03 AM, Greg Kroah-Hartman >... >> My own preference is to rewrite the apex driver entirely in-kernel and >> pull in its userspace parts here. If

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-16 Thread Todd Poynor
On Sat, Jul 14, 2018 at 1:25 AM, Dmitry Torokhov wrote: > On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor wrote: >> >> From: Todd Poynor >> >> Always allow root to open device for writing. >> >> Drop special-casing of ioctl permissions for root vs. owner. >> >> Reported-by: Dmitry Torokhov >> Signe

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Greg Kroah-Hartman
On Sun, Jul 15, 2018 at 11:15:26AM -0700, Todd Poynor wrote: > On Sun, Jul 15, 2018 at 3:03 AM, Greg Kroah-Hartman > wrote: > > On Sun, Jul 15, 2018 at 12:53:09PM +0300, Dmitry Torokhov wrote: > >> > I can't wait for people to just realize this whole "new" subsystem can > >> > be replaced with UIO

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Todd Poynor
On Sun, Jul 15, 2018 at 3:03 AM, Greg Kroah-Hartman wrote: > On Sun, Jul 15, 2018 at 12:53:09PM +0300, Dmitry Torokhov wrote: >> > I can't wait for people to just realize this whole "new" subsystem can >> > be replaced with UIO, but that's a topic for a different thread... >> >> Yes, that is true

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Greg Kroah-Hartman
On Sun, Jul 15, 2018 at 12:53:09PM +0300, Dmitry Torokhov wrote: > > I can't wait for people to just realize this whole "new" subsystem can > > be replaced with UIO, but that's a topic for a different thread... > > Yes, that is true and that is why I am not sure why we are going > through all this

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Dmitry Torokhov
On Sun, Jul 15, 2018 at 12:32 PM Greg Kroah-Hartman wrote: > > On Sun, Jul 15, 2018 at 12:11:47PM +0300, Dmitry Torokhov wrote: > > On Sun, Jul 15, 2018 at 12:05 PM Greg Kroah-Hartman > > wrote: > > > > > > On Fri, Jul 13, 2018 at 10:58:09PM -0700, Todd Poynor wrote: > > > > From: Todd Poynor >

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Greg Kroah-Hartman
On Sun, Jul 15, 2018 at 12:11:47PM +0300, Dmitry Torokhov wrote: > On Sun, Jul 15, 2018 at 12:05 PM Greg Kroah-Hartman > wrote: > > > > On Fri, Jul 13, 2018 at 10:58:09PM -0700, Todd Poynor wrote: > > > From: Todd Poynor > > > > > > Always allow root to open device for writing. > > > > > > Drop s

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Dmitry Torokhov
On Sun, Jul 15, 2018 at 12:05 PM Greg Kroah-Hartman wrote: > > On Fri, Jul 13, 2018 at 10:58:09PM -0700, Todd Poynor wrote: > > From: Todd Poynor > > > > Always allow root to open device for writing. > > > > Drop special-casing of ioctl permissions for root vs. owner. > > > > Reported-by: Dmitry

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:09PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Always allow root to open device for writing. > > Drop special-casing of ioctl permissions for root vs. owner. > > Reported-by: Dmitry Torokhov > Signed-off-by: Zhongze Hu > Signed-off-by: Todd Poynor > ---

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-14 Thread Dmitry Torokhov
On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor wrote: > > From: Todd Poynor > > Always allow root to open device for writing. > > Drop special-casing of ioctl permissions for root vs. owner. > > Reported-by: Dmitry Torokhov > Signed-off-by: Zhongze Hu > Signed-off-by: Todd Poynor I think this pa

[PATCH 11/18] staging: gasket: always allow root open for write

2018-07-13 Thread Todd Poynor
From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 9 +++-- drivers/staging/gasket/gas