RE: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

2015-11-12 Thread Luick, Dean
> -Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, November 11, 2015 11:24 AM > > If you move the variables to the top and have the early return as you > > suggest, > then in some CONFIG cases, there will be all those automatic

Re: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

2015-11-11 Thread Dan Carpenter
On Wed, Nov 11, 2015 at 02:33:32AM -0500, Jubin John wrote: > +static int read_efi_var(const char *name, unsigned long *size, > + void **return_data) > +{ > + int ret; > + > + /* set failure return values */ > + *size = 0; > + *return_data = NULL; > + > + /*

Re: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

2015-11-11 Thread gre...@linuxfoundation.org
hn, Jubin <jubin.j...@intel.com>; de...@driverdev.osuosl.org; > > gre...@linuxfoundation.org; dledf...@redhat.com; linux- > > r...@vger.kernel.org > > Subject: Re: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device > > description > > > > > > >

Re: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

2015-11-11 Thread Dan Carpenter
M > > To: John, Jubin <jubin.j...@intel.com> > > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > > r...@vger.kernel.org; dledf...@redhat.com > > Subject: Re: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device > > description &

RE: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

2015-11-11 Thread Luick, Dean
rg; dledf...@redhat.com; linux- > r...@vger.kernel.org > Subject: Re: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device > description > > > > > + if (efi_enabled(EFI_RUNTIME_SERVICES)) { > > > > > > > > > Flip this around: >

RE: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

2015-11-11 Thread Luick, Dean
verdev.osuosl.org; linux- > r...@vger.kernel.org; dledf...@redhat.com > Subject: Re: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device > description > > On Wed, Nov 11, 2015 at 02:33:32AM -0500, Jubin John wrote: > > +static int read_efi_var(const char *name, unsi

[PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

2015-11-10 Thread Jubin John
From: Dean Luick Read an EFI variable for the device description. Create the infrastructure for additional variable reads. Reviewed-by: Easwar Hariharan Signed-off-by: Dean Luick Signed-off-by: Jubin John