Re: [PATCH 12/14] i2c-parport: return proper error values from attach

2015-04-09 Thread Wolfram Sang
> It doesn't really matter that the error codes are different, it matters > that they are meaningful. As much as possible you should pass error > codes from the lower layers. parport_claim_or_block() and > i2c_bit_add_bus() return proper error codes so you should record and > transmit them. Oh, s

Re: [PATCH 12/14] i2c-parport: return proper error values from attach

2015-04-09 Thread Jean Delvare
On Thu, 9 Apr 2015 09:13:07 +0200, Wolfram Sang wrote: > On Wed, Apr 08, 2015 at 04:50:38PM +0530, Sudip Mukherjee wrote: > > now that we are monitoring the return value from attach, make the > > required changes to return proper value from its attach function. > > > > Signed-off-by: Sudip Mukherj

Re: [PATCH 12/14] i2c-parport: return proper error values from attach

2015-04-09 Thread Wolfram Sang
On Wed, Apr 08, 2015 at 04:50:38PM +0530, Sudip Mukherjee wrote: > now that we are monitoring the return value from attach, make the > required changes to return proper value from its attach function. > > Signed-off-by: Sudip Mukherjee > --- > drivers/i2c/busses/i2c-parport.c | 7 --- > 1 fi

[PATCH 12/14] i2c-parport: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/i2c/busses/i2c-parport.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2