Convert FFS_ERROR to -EINVAL

Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
 drivers/staging/exfat/exfat.h       |  1 -
 drivers/staging/exfat/exfat_core.c  |  8 ++++----
 drivers/staging/exfat/exfat_super.c | 20 ++++++++++----------
 3 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 505751bf1817..2ca2710601ae 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -216,7 +216,6 @@ static inline u16 get_row_index(u16 i)
 #define FFS_SEMAPHOREERR        6
 #define FFS_NOTOPENED           12
 #define FFS_MAXOPENED           13
-#define FFS_ERROR               19
 
 #define NUM_UPCASE              2918
 
diff --git a/drivers/staging/exfat/exfat_core.c 
b/drivers/staging/exfat/exfat_core.c
index 7e637a8e19d3..7efc5d08cada 100644
--- a/drivers/staging/exfat/exfat_core.c
+++ b/drivers/staging/exfat/exfat_core.c
@@ -587,7 +587,7 @@ void exfat_chain_cont_cluster(struct super_block *sb, u32 
chain, s32 len)
 static s32 __load_upcase_table(struct super_block *sb, sector_t sector,
                               u32 num_sectors, u32 utbl_checksum)
 {
-       int i, ret = FFS_ERROR;
+       int i, ret = -EINVAL;
        u32 j;
        struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
        struct bd_info_t *p_bd = &(EXFAT_SB(sb)->bd_info);
@@ -662,7 +662,7 @@ static s32 __load_upcase_table(struct super_block *sb, 
sector_t sector,
                        brelse(tmp_bh);
                return FFS_SUCCESS;
        }
-       ret = FFS_ERROR;
+       ret = -EINVAL;
 error:
        if (tmp_bh)
                brelse(tmp_bh);
@@ -672,7 +672,7 @@ static s32 __load_upcase_table(struct super_block *sb, 
sector_t sector,
 
 static s32 __load_default_upcase_table(struct super_block *sb)
 {
-       int i, ret = FFS_ERROR;
+       int i, ret = -EINVAL;
        u32 j;
        struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
 
@@ -847,7 +847,7 @@ static s32 __write_partial_entries_in_entry_set(struct 
super_block *sb,
        return FFS_SUCCESS;
 err_out:
        pr_debug("%s failed\n", __func__);
-       return FFS_ERROR;
+       return -EINVAL;
 }
 
 /* write back all entries in entry set */
diff --git a/drivers/staging/exfat/exfat_super.c 
b/drivers/staging/exfat/exfat_super.c
index 485297974ae7..0ce27a6babee 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -492,7 +492,7 @@ static int ffsGetVolInfo(struct super_block *sb, struct 
vol_info_t *info)
 
        /* check the validity of pointer parameters */
        if (!info)
-               return FFS_ERROR;
+               return -EINVAL;
 
        /* acquire the lock for file system critical section */
        down(&p_fs->v_sem);
@@ -555,7 +555,7 @@ static int ffsLookupFile(struct inode *inode, char *path, 
struct file_id_t *fid)
 
        /* check the validity of pointer parameters */
        if (!fid || !path || (*path == '\0'))
-               return FFS_ERROR;
+               return -EINVAL;
 
        /* acquire the lock for file system critical section */
        down(&p_fs->v_sem);
@@ -648,7 +648,7 @@ static int ffsCreateFile(struct inode *inode, char *path, 
u8 mode,
 
        /* check the validity of pointer parameters */
        if (!fid || !path || (*path == '\0'))
-               return FFS_ERROR;
+               return -EINVAL;
 
        /* acquire the lock for file system critical section */
        down(&p_fs->v_sem);
@@ -697,7 +697,7 @@ static int ffsReadFile(struct inode *inode, struct 
file_id_t *fid, void *buffer,
 
        /* check the validity of pointer parameters */
        if (!buffer)
-               return FFS_ERROR;
+               return -EINVAL;
 
        /* acquire the lock for file system critical section */
        down(&p_fs->v_sem);
@@ -827,7 +827,7 @@ static int ffsWriteFile(struct inode *inode, struct 
file_id_t *fid,
 
        /* check the validity of pointer parameters */
        if (!buffer)
-               return FFS_ERROR;
+               return -EINVAL;
 
        /* acquire the lock for file system critical section */
        down(&p_fs->v_sem);
@@ -1232,7 +1232,7 @@ static int ffsMoveFile(struct inode *old_parent_inode, 
struct file_id_t *fid,
 
        /* check the validity of pointer parameters */
        if (!new_path || (*new_path == '\0'))
-               return FFS_ERROR;
+               return -EINVAL;
 
        /* acquire the lock for file system critical section */
        down(&p_fs->v_sem);
@@ -1455,7 +1455,7 @@ static int ffsSetAttr(struct inode *inode, u32 attr)
                if (p_fs->dev_ejected)
                        ret = -EIO;
                else
-                       ret = FFS_ERROR;
+                       ret = -EINVAL;
 
                if (p_fs->vol_type == EXFAT)
                        release_entry_set(es);
@@ -1747,7 +1747,7 @@ static int ffsMapCluster(struct inode *inode, s32 
clu_offset, u32 *clu)
 
        /* check the validity of pointer parameters */
        if (!clu)
-               return FFS_ERROR;
+               return -EINVAL;
 
        /* acquire the lock for file system critical section */
        down(&p_fs->v_sem);
@@ -1899,7 +1899,7 @@ static int ffsCreateDir(struct inode *inode, char *path, 
struct file_id_t *fid)
 
        /* check the validity of pointer parameters */
        if (!fid || !path || (*path == '\0'))
-               return FFS_ERROR;
+               return -EINVAL;
 
        /* acquire the lock for file system critical section */
        down(&p_fs->v_sem);
@@ -1945,7 +1945,7 @@ static int ffsReadDir(struct inode *inode, struct 
dir_entry_t *dir_entry)
 
        /* check the validity of pointer parameters */
        if (!dir_entry)
-               return FFS_ERROR;
+               return -EINVAL;
 
        /* check if the given file ID is opened */
        if (fid->type != TYPE_DIR)
-- 
2.23.0

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to