Re: [PATCH 134/141] staging: unisys: Hide vbus_hdr_info from public visor_device

2015-05-11 Thread Don Zickus
On Sat, May 09, 2015 at 12:19:28PM +0300, Dan Carpenter wrote: On Fri, May 08, 2015 at 04:07:03PM +0300, Dan Carpenter wrote: This function leaks hdr_info on later error paths. Never mind. I'm wrong. Sorry for the noise. To be honest, I think I was right originally, but the

Re: [PATCH 134/141] staging: unisys: Hide vbus_hdr_info from public visor_device

2015-05-09 Thread Dan Carpenter
On Sat, May 09, 2015 at 12:19:28PM +0300, Dan Carpenter wrote: On Fri, May 08, 2015 at 04:07:03PM +0300, Dan Carpenter wrote: This function leaks hdr_info on later error paths. Never mind. I'm wrong. Sorry for the noise. To be honest, I think I was right originally, but the

Re: [PATCH 134/141] staging: unisys: Hide vbus_hdr_info from public visor_device

2015-05-09 Thread Dan Carpenter
On Fri, May 08, 2015 at 04:07:03PM +0300, Dan Carpenter wrote: This function leaks hdr_info on later error paths. Never mind. I'm wrong. Sorry for the noise. To be honest, I think I was right originally, but the code is such a twisty call path that it's hard to tell. Of course, what

Re: [PATCH 134/141] staging: unisys: Hide vbus_hdr_info from public visor_device

2015-05-08 Thread Dan Carpenter
On Tue, May 05, 2015 at 06:37:51PM -0400, Benjamin Romer wrote: From: Don Zickus dzic...@redhat.com @@ -1230,8 +1231,16 @@ create_bus_instance(struct visor_device *vdev) { int rc; u32 id = vdev-chipset_bus_no; + struct spar_vbus_headerinfo *hdr_info;

Re: [PATCH 134/141] staging: unisys: Hide vbus_hdr_info from public visor_device

2015-05-08 Thread Dan Carpenter
On Fri, May 08, 2015 at 11:34:57AM +0300, Dan Carpenter wrote: On Tue, May 05, 2015 at 06:37:51PM -0400, Benjamin Romer wrote: From: Don Zickus dzic...@redhat.com @@ -1230,8 +1231,16 @@ create_bus_instance(struct visor_device *vdev) { int rc; u32 id = vdev-chipset_bus_no; +

[PATCH 134/141] staging: unisys: Hide vbus_hdr_info from public visor_device

2015-05-05 Thread Benjamin Romer
From: Don Zickus dzic...@redhat.com The vbus_hdr_info is a private struct that is used to communicate bus info over the channel. Currently it is public in visorbus.h and causes compile problems (missing header). Fix this by allocating memory and turn the public element into a pointer.