Re: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues

2018-12-17 Thread Marc Dietrich
Hi, On Mon, 17 Dec 2018, Greg KH wrote: On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote: @@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) break; case 2: /* first byte after command */ if (status ==

Re: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues

2018-12-17 Thread Greg KH
On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote: > @@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) > break; > case 2: /* first byte after command */ > if (status == (I2C_SL_IRQ | RNW | RCVD)) { > -

Re: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues

2018-12-16 Thread kbuild test robot
Hi Amir, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.20-rc7 next-20181214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-c

Re: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues

2018-12-16 Thread Joe Perches
On Sun, 2018-12-16 at 08:57 -0800, Amir Mahdi Ghorbanian wrote: > Fixed an endline open parenthesis issue and replaced udelay() by the > preferred usleep_range() function. Not all checkpatch bleats need to be fixed. Function names with 40+ character length identifiers makes fitting within an 80 c

[PATCH 2/2] Staging: nvec: nvec: fixed check style issues

2018-12-16 Thread Amir Mahdi Ghorbanian
Fixed an endline open parenthesis issue and replaced udelay() by the preferred usleep_range() function. Signed-off-by: Amir Mahdi Ghorbanian --- drivers/staging/nvec/nvec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/stagin